Page MenuHomePhabricator

Flow: garbled and generic "Internal error - {{SITENAME}}" for Flow error page titles
Closed, ResolvedPublic

Description

Part 1

Visit https://www.mediawiki.org/wiki/Talk:Sandbox?workflow=abcd , the h1 and page title are

Internal error - {{SITENAME}}

Appending &uselang=qqx suggests the message is

(pagetitle: (internalerror))
(flow-error-invalid-action)

So the pagetitle message is looked up, but isn't getting parsed.

Part 2

Visit https://www.mediawiki.org/wiki/Talk:Sandbox?action=FOO , the h1 and page title are the same Internal error - {{SITENAME}}
Flow's InvalidActionException->getErrorPageTitle() is returning the better title 'nosuchaction' for this error, but it isn't appearing.


Version: master
Severity: normal
URL: https://www.mediawiki.org/wiki/Talk:Sandbox?action=FOO

Details

Reference
bz62165

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz62165.
Spage created this task.Mar 3 2014, 9:16 PM

Change 116631 had a related patch set uploaded by Spage:
Fix error page titles

https://gerrit.wikimedia.org/r/116631

(In reply to spage from comment #0)

So the pagetitle message is looked up, but isn't getting parsed.

That is bug 58447.

(In reply to Kevin Israel (PleaseStand) from comment #2)

(In reply to spage from comment #0)
> So the pagetitle message is looked up, but isn't getting parsed.

That is bug 58447.

Beyond that bug, Flow is creating its own OutputPage object that has no message handling hooked up at all.

Change 116631 abandoned by Spage:
Fix error page titles

Reason:
Yup, it's not this simple. I still think we can get ErrorPageError to do the work for us, just pass the full 'flow-error-CODE' at all times. It's crazy that ErrorPageError can't log the full $message text while displaying something friendlier to the user.

https://gerrit.wikimedia.org/r/116631

Change 120708 had a related patch set uploaded by Bsitu:
Replace generic "Internal error - {{SITENAME}}" on error page

https://gerrit.wikimedia.org/r/120708

Change 120708 merged by jenkins-bot:
Replace generic "Internal error - {{SITENAME}}" on error page

https://gerrit.wikimedia.org/r/120708

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM