Page MenuHomePhabricator

mediawiki_selenium Ruby gem should be able to start local and remote browsers with optional browser setup
Closed, ResolvedPublic

Description

In the MobileFrontend repo there is a test no_"javascript_site.feature"

That test uses this step in common_steps.rb:

Given /^I am using user agent "(.+)"$/ do |user_agent|

@user_agent = user_agent
@browser = browser(environment, test_name(@scenario), user_agent)
@browser.window.resize_to(480, 800)
$session_id = @browser.driver.instance_variable_get(:@bridge).session_id

end

None of this works since browser creation has moved to shared code.

We should make it possible to have Firefox honor spoofing a user agent string. (Note: no browser other than Firefox will spoof a user agent.)


Version: unspecified
Severity: normal

Details

Reference
bz62512

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz62512.

Change 118720 had a related patch set uploaded by Zfilipin:
WIP QA: Update mediawiki_selenium gem to honor optional useragent string per MobileFrontend

https://gerrit.wikimedia.org/r/118720

Change 118721 had a related patch set uploaded by Zfilipin:
WIP Update mediawiki_selenium gem to honor optional useragent string per MobileFrontend

https://gerrit.wikimedia.org/r/118721

Change 119270 had a related patch set uploaded by Zfilipin:
WIP mediawiki_selenium Ruby gem should be able to start local and remote browsers with optional browser setup

https://gerrit.wikimedia.org/r/119270

Change 119271 had a related patch set uploaded by Zfilipin:
WIP mediawiki_selenium Ruby gem should be able to start local and remote browsers with optional browser setup

https://gerrit.wikimedia.org/r/119271

Change 119272 had a related patch set uploaded by Zfilipin:
WIP mediawiki_selenium Ruby gem should be able to start local and remote browsers with optional browser setup

https://gerrit.wikimedia.org/r/119272

Change 118721 abandoned by Zfilipin:
WIP Update mediawiki_selenium gem to honor optional useragent string per MobileFrontend

Reason:
better implementation in https://gerrit.wikimedia.org/r/#/c/119272/

https://gerrit.wikimedia.org/r/118721

Change 119272 merged by Cmcmahon:
mediawiki_selenium Ruby gem should be able to start local and remote browsers with optional browser setup

https://gerrit.wikimedia.org/r/119272

Change 118720 abandoned by Zfilipin:
WIP QA: Update mediawiki_selenium gem to honor optional useragent string per MobileFrontend

Reason:
Better implementation is at https://gerrit.wikimedia.org/r/#/c/119271

https://gerrit.wikimedia.org/r/118720

As far as I am concerned, this is resolved. Please reopen if needed.

Change 119487 had a related patch set uploaded by Zfilipin:
A cookie can optionally be set when starting the browser

https://gerrit.wikimedia.org/r/119487

Change 119487 merged by Cmcmahon:
A cookie can optionally be set when starting the browser

https://gerrit.wikimedia.org/r/119487

Change 119490 had a related patch set uploaded by Zfilipin:
Fixed setting a cookie when starting the browser.

https://gerrit.wikimedia.org/r/119490

Change 119490 merged by jenkins-bot:
Fixed setting a cookie when starting the browser.

https://gerrit.wikimedia.org/r/119490

Change 119271 merged by jenkins-bot:
QA: Using the new way of starting a custom browser

https://gerrit.wikimedia.org/r/119271

Change 119270 merged by jenkins-bot:
Using the new way of starting a custom browser

https://gerrit.wikimedia.org/r/119270