Upgrade git > 1.7
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	• GWicke
	Mar 11 2014, 1:28 AM

Description

Git 1.7.9 has an annoying bug in that it uses absolute paths when initializing submodules. In the best case, this breaks git within the submodule when the full checkout is transferred to another host. In the worst case, it leads to incorrect git behavior within the submodule.

This affects parsoid round-trip testing. We currently use rsync to distribute the code from the central checkout, which provokes this issue. Clients are checking the git revision of the submodule and exit if it has changed. They also report the revision to the round-trip test server. In the worst case this means that test results are attributed to the wrong revision.

This was fixed in git 1.7.10, March 2012:

http://thread.gmane.org/gmane.comp.version-control.git/192173

Version: wmf-deployment
Severity: enhancement

Details

Reference: bz62519

Related Objects
Search...

Status	Assigned	Task
Declined	hashar	T64519 Upgrade git > 1.7
Declined	None	T65899 Upgrade Wikimedia servers to Ubuntu Trusty (14.04)
Resolved	Krinkle	T70256 Jenkins: Set up integration slaves with Ubuntu Trusty
Resolved	fgiunchedi	T70255 [OPS] Jenkins: Package php5-parsekit missing in Trusty
Resolved	akosiaris	T70257 [OPS] Jenkins: Package ruby-jsduck missing in Trusty
Resolved	hashar	T70340 Jenkins: label slaves with their ubuntu version
Resolved	akosiaris	T70995 [OPS] Upgrade Jenkins Debian Glue from 0.8.1 to 0.10.0
Resolved	Andrew	T62684 Virtual image for Ubuntu Trusty (14.04)
Resolved	Joe	T84842 Convert eqiad imagescalers to HHVM, Trusty
Resolved	tstarling	T91468 HHVM with FastCGI does not support streaming output
Resolved	Joe	T93194 Create an HHVM 3.6.0 package, adding Tim's streaming patch
Resolved	Joe	T87036 Convert work machines (tin, terbium) to Trusty and hhvm usage
Resolved	Joe	T116728 Reimage mw1152 as a terbium replacement
Resolved	Joe	T124024 Be able to switch programmatically between deployment servers in codfw and eqiad
Resolved	Dzahn	T94585 distribution upgrade for wikitech-static instance
Resolved	Joe	T104747 Convert tmh100[12] to HHVM and trusty
Duplicate	fgiunchedi	T107313 Backport ffmpeg 2.7.3 to Trusty
Resolved	• brion	T69953 ogv transcodes have broken audio tracks with ffmpeg2theora 0.29 (Trusty upstream)
Resolved	• brion	T103335 Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie)
Resolved	bd808	T110707 Upgrade Beta Cluster tmh* host(s) to HHVM and Trusty
Resolved	Joe	T113284 Frequent job timeouts on HHVM video scalers
Declined	ArielGlenn	T94277 Convert snapshot hosts to use HHVM and trusty
Resolved	ArielGlenn	T111586 Snapshot hosts need to be manually added to dataset1001's exports
Resolved	ori	T113932 HHVM does not recognize compress.bzip2 streams
Declined	None	T117534 DCAT-AP: XML produces invalid output with HHVM
Resolved	MoritzMuehlenhoff	T143648 Merge facebook/hhvm@9d2be6c30b into build of next hhvm release

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:59 AM

• bzimport added a project: Gerrit.

• bzimport set Reference to bz62519.

• bzimport added a subscriber: Unknown Object (MLST).

• GWicke created this task.Mar 11 2014, 1:28 AM

This would mean backporting the git package from a newer Ubuntu release, that's up to ops :)

If the only complaint is submodule init I don't think it's worth it IMHO.

14.04 has 1.9

• demon unsubscribed.Dec 8 2014, 6:25 PM

Should this be closed since Wikimedia uses gerrit and gitblit now. and soon to be phabricator.

In T64519#1212753, @Paladox wrote:

Should this be closed since Wikimedia uses gerrit and gitblit now. and soon to be phabricator.

That is irrelevant.

This task is about use of the Git client between servers. Gerrit and Phabricator provide Git repositories with source code, they are not clients, and they do not actually run the source code. The source code is deployed from Gerrit to actual application servers. This task about using Git and rsync to pull data from Gerrit and deploy it to the application servers.