Page MenuHomePhabricator

Code hygiene: Having a KeepGoingOverlay and KeepGoingDrawer is confusing
Closed, ResolvedPublic


Both look identical making development on this feature hard. Let's get this JavaScript code consolidated.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:01 AM
bzimport set Reference to bz62543.
bzimport added a subscriber: Unknown Object (MLST).

Fixing this bug means deciding what we want to do with the random campaign feature. If we're keeping it, we consolidate the code. If we're not keeping it, we ditch the KeepGoingDrawer and let the KeepGoingOverlay remain relatively simple.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card

The random feature came out of the fact the KeepGoingDrawer was a generic reusable component, it seems KeepGoingOverlay is less generic now so that's why it isn't using it.

I think regardless of whether we keep the random feature this would be a good exercise for future developments using the keep going overlay (also I think the KeepGoingOverlay name is a bit misleading - KeepGoingOverlayDrawer sounds more descriptive).

KeepGoingDrawer doesn't exist anymore.