Page MenuHomePhabricator

Flow: Reply • Edit buttons don't highlight or click
Closed, ResolvedPublic

Description

The Reply • Edit (and • Thanks) "buttons" for a post don't do anything when you hover and click on them. They should work like the Cancel button.

The fix is to style them mw-ui-button mw-ui-quiet , and then subtract the margins and bolding of mw-ui-quiet. May Galloway calls these "light" buttons, maybe that style should be part of Agora in core. For now either customize .flow-post-interaction .mw-ui-button.mw-ui-quiet , or define a new style {flow/mw}-ui-light.

Also related to bug 62297 (gerrit 113066). When these bugs are fixed the .flow-post-interaction-separator CSS can be updated and simplified.


Version: master
Severity: normal

Details

Reference
bz62556

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:02 AM
bzimport set Reference to bz62556.
bzimport added a subscriber: Unknown Object (MLST).

I think Reply & Edit should also be mw-ui-progressive (blue on hover/click) and Thank should be mw-ui-constructive (green on hover/click).

Tracked in https://trello.com/c/wBiXSreC
Moving this "light" or "inline" style to core mediawiki.ui is bug 62744.

Change 119812 had a related patch set uploaded by Bencmq:
Apply hover/click highlight to post interaction links

https://gerrit.wikimedia.org/r/119812

Change 119814 had a related patch set uploaded by Bencmq:
Add hover highlight to Thank link in Flow posts

https://gerrit.wikimedia.org/r/119814

Change 119814 merged by jenkins-bot:
Add hover highlight to Thank link in Flow posts

https://gerrit.wikimedia.org/r/119814

Change 119812 merged by jenkins-bot:
Reorganise flow-post-interaction link styling

https://gerrit.wikimedia.org/r/119812

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM