Page MenuHomePhabricator

VisualEditor: Beat the reference toolbar button in the reference dialog back down into its grave
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page in VE
2.Insert a reference
3.Open the reference dialog
4.Insert another reference inside it
5.Save the page

Observed Result:
In read mode :Cite error: Closing </ref> missing for <ref> tag appears
Inside VE: for the reference that is inside another reference, the wikitext appears in the reflist section

See the screenshots attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz62575

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:03 AM
bzimport set Reference to bz62575.
Ryasmeen created this task.Mar 12 2014, 7:42 PM

Created attachment 14794
Wikitext in the reflist

Attached:

Adding references inside of references shouldn't be possible. That toolbar button is supposed to be hidden. Repurposing bug.

However, we should verify that we deal correctly with cases where this has already been done in wikitext.

Change 119704 had a related patch set uploaded by Catrope:
Followup 861d097: actually exclude reference tool in reference dialog toolbar

https://gerrit.wikimedia.org/r/119704

(In reply to Roan Kattouw from comment #2)

Adding references inside of references shouldn't be possible. That toolbar
button is supposed to be hidden. Repurposing bug.

Turned out to be an accidental overcorrection from fixing bug 62286.

Change 119704 merged by jenkins-bot:
Followup 861d097: actually exclude reference tool in reference dialog toolbar

https://gerrit.wikimedia.org/r/119704