Page MenuHomePhabricator

VisualEditor: [Regression wmf18] If you insert an image into the page with default settings, save, then re-open the page without refresh, JS errors on load
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Save the page
4.Reopen the page
5.Open the media settings for the image

Observed Result:
The following error appears in the console and Media Settings dialog box cannot be closed:

Uncaught TypeError:Cannot read property 'width' of null
Uncaught TypeError:Cannot call method 'getItemFromData'of undefined.

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=12thmarchchrome


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz62581

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:03 AM
bzimport set Reference to bz62581.
Ryasmeen created this task.Mar 12 2014, 9:34 PM

Change 118427 had a related patch set uploaded by Mooeypoo:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118427

Change 118601 had a related patch set uploaded by Catrope:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118601

Change 118427 merged by jenkins-bot:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118427

Still occurring after the above patch. :-(

I've re-worded the bug title based on my understanding. The issue is probably in the binding of the variable – note that everything is fine as soon as you refresh the page, the problem is when you re-load VE on the same page (so re-using a lot of the VE running code).

(In reply to James Forrester from comment #4)

Still occurring after the above patch. :-(

Belay that, now working. Probably browser cache issues. *sigh*

(Thanks, Moriel!)

Change 118601 merged by jenkins-bot:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118601