Page MenuHomePhabricator

VisualEditor: [Regression wmf18] Making an image Right, Basic and Border does not include the Right and Border in the wikitext
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a page with VE
2.Now change the image settings to Right,Basic and Border
3.Save the page

Observed Result:
In the wikitext the options "Right" and "Border" are missing

Test Environment: http://en.wikipedia.beta.wmflabs.org/
: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5


Version: unspecified
Severity: normal

Details

Reference
bz62852

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:04 AM
bzimport set Reference to bz62852.

Created attachment 14864
Screenshot

Attached:

Parsoid does the right thing with the input giving the expected output:

<figure class="mw-default-size mw-halign-right mw-image-border" typeof="mw:Image" data-parsoid="{&quot;optList&quot;:[{&quot;ck&quot;:&quot;thumbnail&quot;,&quot;ak&quot;:&quot;thumb&quot;},{&quot;ck&quot;:&quot;left&quot;,&quot;ak&quot;:&quot;left&quot;},{&quot;ck&quot;:&quot;caption&quot;,&quot;ak&quot;:&quot;Foo&quot;}],&quot;dsr&quot;:[0,35,2,2]}"><a href="./File:Example.png" data-parsoid="{&quot;a&quot;:{&quot;href&quot;:&quot;./File:Example.png&quot;},&quot;dsr&quot;:[2,null,null,null]}"><img resource="./File:Example.png" src="//upload.wikimedia.org/wikipedia/en/thumb/7/70/Example.png/220px-Example.png" height="238" width="220" data-parsoid="{&quot;a&quot;:{&quot;resource&quot;:&quot;./File:Example.png&quot;,&quot;height&quot;:&quot;238&quot;,&quot;width&quot;:&quot;220&quot;},&quot;sa&quot;:{&quot;resource&quot;:&quot;File:Example.png&quot;}}"></a><figcaption data-parsoid="{&quot;dsr&quot;:[null,33,null,null]}">Foo</figcaption></figure>

->

[[File:Example.png|Foo|right|border]]

CE responds correctly to the type and alignment shifts, and yet something seems to goes awry in the DM. I'm checking into the issue.

So, this is still happening.In addition to that, for all Right aligned Images regardless of its type the alignment options gets missing from the wikitext

Skipping right (and just using default) is OK for thumb and frame (but not frameless or basic).

Verified the fix in Betalabs

Verified the fix in test2