Page MenuHomePhabricator

refactor "upload file" step to mediawiki_selenium gem
Closed, DeclinedPublic


I updated the MobileFrontend repo such that the there is a step "When(/^upload file (.+)$/) do |file_name|" that exactly matches the same step in the UploadWizard repo. The MobileFrontend version was broken in several ways, notably for Chrome.

There is also a step in the MobileFrontend repo "When(/^upload bogus file (.+)$/) do |file_name|" that should also probably move to shared gem.

Rather than duplicate code, we should put these identical steps in the shared steps of the mediawiki_selenium gem.

If we want to do further refactoring, we should do it in the mediawiki_selenium gem and not in the individual repos.

Version: unspecified
Severity: major
Whiteboard: zfilipin
See Also:



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:06 AM
bzimport set Reference to bz62888.
bzimport added a subscriber: Unknown Object (MLST).

Uploads code is gone from mobile, not sure if you guys want to add this to the selenium gem for future use.