Page MenuHomePhabricator

Hovercards: empty cards should never be generated
Closed, ResolvedPublic

Description

Sometimes it seems there are empty dialogs. Can we avoid showing the hover cards in these situations or fix this? [1]

[1] https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topic_postId=rri0cyxphqyu8cp1&workflow=rrc19ij5nimkme01#flow-post-rri0cyxphqyu8cp1


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63792

Details

Reference
bz62994

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:56 AM
bzimport added a project: Page-Previews.
bzimport set Reference to bz62994.
Prtksxna created this task.Mar 24 2014, 4:43 AM

Created attachment 14888
testcase

Attached:

Created attachment 15078
Screenshot of Hovercard and Navpopup for same link

Attached:

Created attachment 15079
Wiktionary screenshot of Hovercard and Navpopup for same link

Attached:

One of the problems seems to be, that it is ignoring text that appears after a section heading.
This is a site-wide problem for En.Wiktionary content, because they don't use intro sentences at all.

Would it help to change the "exintro" parameter of [[mw:Extension:TextExtracts#API]]? (I'm not sure what other repercussions that might have)

So two things here:

  1. If the extract we get back is empty, we just should not display a card. This is a HoverCards issue that should be easy to fix.
  2. If an extract is empty when it shouldn't be, file separate bugs against TextExtracts.

Change 129402 had a related patch set uploaded by Prtksxna:
Stop Popups from being generated if extract is empty

https://gerrit.wikimedia.org/r/129402

Change 129402 merged by jenkins-bot:
Stop Popups from being generated if extract is empty

https://gerrit.wikimedia.org/r/129402

Prtksxna raised the priority of this task from Normal to Needs Triage.Dec 3 2014, 5:30 AM
Prtksxna moved this task from Backlog to Archive on the Page-Previews board.