Page MenuHomePhabricator

Nosetests / codecoverage packages missing from wikimetrics' setup
Closed, DeclinedPublic

Description

When installing wikimetrics through vagrant, nosetests and codecoverage are not
installed per default. So one cannot run the nosetests due to missing
dependencies.

Can we install nosetests/codecoverage in vagrant's wikimetrics role?


Version: unspecified
Severity: normal

Details

Reference
bz63002

Related Objects

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:57 AM
bzimport set Reference to bz63002.
bzimport added a subscriber: Unknown Object (MLST).
QChris created this task.Mar 24 2014, 10:34 AM
Nuria added a comment.Mar 24 2014, 1:05 PM

I believe vagrant roles do not setup testing infrastructure for roles via puppet. You are expected to pip install nose. At least that is the case in the roles I have installed.

I am not sure this is a bug.

(In reply to nuria from comment #1)

You are expected to pip install nose.

Then the bug is that this necessary step is not documented anywhere :-)

(In reply to christian from comment #2)

Then the bug is that this necessary step is not documented anywhere :-)

Rubbish, Christian!

No need to change the documentation, when we can fix the install procedure and
install nosetests, and codecoverage. Thereby making wikimetrics development
easier.

(As I've been told that Andrew opposed, I asked him via email, and it turned
out that he does not oppose installing nosetests and codecoverage
to vagrant's wikimetrics role.)
So let's have nosetests and codecoverage installed in vagrant's wikimetrics
role. \o/

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/analytics/cards/cards/1494

Just to keep track of what was said in private emails, one suggestion was to
turn the current $debug into something more generic:

$environment = ‘development’,
…
if $environment == ‘development’ {
    $debug = true
    exec { ‘install_wikimetrics_test_dependencies’:
    …
    }
}
else {
    $debug = false
}

This would cleanly replace code we have like the following:

if (debug)

  1. change some config setting X to Y

With:
if (development)

  1. load development config, it already has X=Y
mforns closed this task as Declined.Mar 26 2019, 1:58 PM
mforns added a subscriber: mforns.

Wikimetrics is being discontinued. See: T211835.

Restricted Application added a project: Analytics. · View Herald TranscriptMar 26 2019, 1:58 PM