Page MenuHomePhabricator

Flow: to oversighters, suppressed edits display as unsuppressed in Special:Contributions
Closed, ResolvedPublic

Description

Struck through edit, showing that it's been suppressed, although the edits underneath it do not appear to be suppressed.

When edits are suppressed, they're typically shown as being struck through.

Although the log entry here shows that the edits were suppressed, they're not struck through in my contributions as I expected. This gives me the appearance that the edits were not suppressed, which caused me to panic. However, if I log out and go to my contributions, the behaviour is correct; the edits do not show up in my contributions, and if I go to the relevant Flow board then there's no indication that the topic that was suppressed was ever there.

Suppressed edits, if they are visible in contributions lists to oversighters, should be struck through to indicate to the oversights that they're suppressed.


Version: unspecified
Severity: minor
Whiteboard: flow_suppression

Attached:

Details

Reference
bz63026

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:58 AM
bzimport set Reference to bz63026.
bzimport added a subscriber: Unknown Object (MLST).

A relatively minor issue, since the edits are actually suppressed properly (although they appear to not be), and if you actually click on the link that should be struck through then the post is properly labelled as "This topic was suppressed by DGarry (WMF)".

Attempting to home in on the issue a little more succinctly in the title; let me know if that reads right to you, Dan :)

Created attachment 14901
Screenshot showing that all suppressed content appears to not be suppressed, except for the suppression log entries

Attached:

(In reply to Maryana Pinchuk from comment #2)

Attempting to home in on the issue a little more succinctly in the title;
let me know if that reads right to you, Dan :)

Some quick testing I did shows that the new summary is incorrect. See attachment 14901 for the results of my testing.

All suppressed content appears unsuppressed in Special:Contributions. The single exception to this is the entry in your contributions showing that you suppressed something, which a) should only be in the suppression log and NOT in your contributions and b) shouldn't be suppressed itself, as the suppression log is only accessible by oversighters.

Change 122414 had a related patch set uploaded by Matthias Mullie:
(bug 63026) to oversighters, suppressed edits display as unsuppressed in Special:Contributions

https://gerrit.wikimedia.org/r/122414

Change 122414 merged by jenkins-bot:
(bug 63026) to oversighters, suppressed edits display as unsuppressed in Special:Contributions

https://gerrit.wikimedia.org/r/122414

Wooo, this is getting even more confusing. Okay, so here's the current behavior with these new patches:

  1. If I'm an oversighter, I can suppress other users' Flow entries. This shows up in my contributions (with a strikethrough) when I'm looking at my contribs with my oversighter privileges <- if I understand you correctly, Dan, this is not feature parity with mediawiki, but it's not a huge deal because it *is* a legit contribution, and users without oversighter privileges can't see this in my contribs.
  1. If I'm not an oversighter, I can't see anything that's been suppressed in Special:Contribs at all, whether those are my contributions or another users' contributions.

But! On ee-flow wiki, as a non-oversighter, I do see a placeholder that something has been suppressed in the contribs of a user who's had a main namespace (non-Flow) revision oversighted. (E.g., the second contrib from the top here: http://ee-flow.wmflabs.org/wiki/Special:Contributions/Maryana). Not sure if this is because we have ee-flow configured differently from enwiki or not...

So I'm even more confused now. Which of these is the expected behavior?

(In reply to Maryana Pinchuk from comment #7)

  1. If I'm an oversighter, I can suppress other users' Flow entries. This

shows up in my contributions (with a strikethrough) when I'm looking at my
contribs with my oversighter privileges <- if I understand you correctly,
Dan, this is not feature parity with mediawiki, but it's not a huge deal
because it *is* a legit contribution, and users without oversighter
privileges can't see this in my contribs.

A placeholder is left in your contributions if you suppress a Flow post, but not if you suppress anything else, which results in poor UI consistency for supression. I think that's is important, but it's not breaking in the sense that suppression isn't working.

So I'd say correct on all counts.

  1. If I'm not an oversighter, I can't see anything that's been suppressed in

Special:Contribs at all, whether those are my contributions or another
users' contributions.

But! On ee-flow wiki, as a non-oversighter, I do see a placeholder that
something has been suppressed in the contribs of a user who's had a main
namespace (non-Flow) revision oversighted. (E.g., the second contrib from
the top here:
http://ee-flow.wmflabs.org/wiki/Special:Contributions/Maryana). Not sure if
this is because we have ee-flow configured differently from enwiki or not...

True. That's because you didn't suppress the username. Using granular suppression, if the username of a contribution is suppressed, then that contribution no longer appears in the contributions for that user, otherwise it'd defeat the point of the suppression.

Look again on ee-flow while logged out, and you'll see it's totally disappeared from your contributions. The reason for that is I did a full suppression, which includes username suppression.

Suppression in Flow is not granular. So you should be consistent with the behaviour of full suppression, not partial suppression.

That said, on ee-flow, if you're an oversighter then you can still see the contribution in Special:Contributions with it marked as not being publicly visible, but if you're on the English Wikipedia then it just doesn't appear at all. I'm unsure what mechanism in the software causes that difference, so I don't know how you'd make Flow aware of that.