Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf20] Cannot save a page after undoing inserting reference on it
Closed, ResolvedPublic

Description

screenshot

There are wide varieties of type errors I get for undoing typing references in different way.I will try to document each cases in this same bug report:

Case 1:

Steps to reproduce:

1.Insert a reference with text for example : reference[1]
2.Press "Undo"

Error 1:
Uncaught TypeError: Cannot read property 'length' of undefined

3.Place the cursor at the end of the text

Error 2:
Uncaught Error: ve.dm.Document.getNodeFromOffset(): offset 12 is out of bounds

Case 2:

1.Insert two references with text , for example:
reference [1]
reference [2]

2.Now keep on pressing Undo untill the page gets empty

Errors:
Uncaught TypeError: Cannot read property 'length' of undefined VM484:296
Uncaught Error: Offset could not be translated to a DOM element and offset: 12 VM484:447
Uncaught Error: Invalid end offset: 21 VM484:252
Uncaught Error: Unbalanced input passed to document

In both cases, after the Undo action , clicking on "Save Page" does not do anything.


Version: unspecified
Severity: major

Attached:

Details

Reference
bz63085

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.
bzimport set Reference to bz63085.
Ryasmeen created this task.Mar 25 2014, 7:26 PM

Created attachment 14904
screenshot 2

Attached:

Change 120874 had a related patch set uploaded by Catrope:
Rename stray this.refGroup usage to this.group in MWReferenceModel

https://gerrit.wikimedia.org/r/120874

Change 120874 merged by jenkins-bot:
Rename stray this.refGroup usage to this.group in MWReferenceModel

https://gerrit.wikimedia.org/r/120874