Page MenuHomePhabricator

"Invalid feed class/item" exceptions from ApiFormatFeedWrapper
Closed, ResolvedPublic

Description

While deploying, I noticed numerous "Internal error in ApiFormatFeedWrapper::execute: Invalid feed class/item" exceptions in fluorine:/a/mw-log/exception.log

2014-03-26 21:40:17 mw1197 enwiki: [659b7cd8] /w/api.php?hidebots=1&days=7&limit=50&hidewikidata=1&action=feedrecentchanges&feedformat=atom Exception from line 2008 of /usr/local/apache/common-local/php-1.23wmf18/includes/api/ApiBase.php: Internal error in ApiFormatFeedWrapper::execute: Invalid feed class/item

in exception.log. All from enwiki. Most are this URL, some are feedformat=rss instead of atom.


Version: unspecified
Severity: normal

Details

Reference
bz63150

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:06 AM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz63150.
bzimport added a subscriber: Unknown Object (MLST).

What appears to be happening here is that an API error is being raised somewhere after the point where the custom feed printer is initialized, and the custom feed printer chokes when asked to print that API error.

I don't see any obvious candidates for the cause of the original error, but that doesn't matter much since this situation should be handled anyway. For testing, this bug can be reproduced by locally editing ApiFeedRecentChanges to throw an exception from its execute() method.

Change 121381 had a related patch set uploaded by Anomie:
API: Allow for format modules that cannot handle errors

https://gerrit.wikimedia.org/r/121381

Change 121381 merged by jenkins-bot:
API: Allow for format modules that cannot handle errors

https://gerrit.wikimedia.org/r/121381

This should be deployed to WMF wikis with 1.23wmf21, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.