Page MenuHomePhabricator

Thanks: Clicking 'Thank' will sometimes just take me to the top of the page
Closed, ResolvedPublic


It seems to be an erratic bug. Possibly a caching issue?

S says "it seems '#' leaks out into the URL, look for it changing"

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
bzimport added a project: Thanks.
bzimport set Reference to bz63205.
bzimport added a subscriber: Unknown Object (MLST).

In Flow, this seems to be reproducible in posts that are loaded in the infinite scroll. Ie. it doesn't affect the first 10 topics, but everything loaded after that will experience the problem.

Change 132150 had a related patch set uploaded by Wctaiwan:
Use .on() instead of .click() for Flow Thanks

  • Bug 65141 has been marked as a duplicate of this bug. ***

The patch has been merged but Gerrit Notification Bot was down. Manually marking as resolved.

Once I48ef5e51fd3ac76ff5caf6907bc53d09357634bd is deployed, if JavaScript hasn't loaded yet, you'll be sent to Special:Thanks instead so this should stop happening.

I've noticed this sees to happen more frequently when you follow a link to a thread from an echo notification…

Change 137537 had a related patch set uploaded by Wctaiwan:
Bind Flow Thank click detection to .flow-container

Change 137537 merged by jenkins-bot:
Bind Flow Thank click detection to .flow-container

Latest issue seems to be fixed. Tested on a post-permalink.
Thanks, Wctaiwan and Legoktm!