Page MenuHomePhabricator

MarkAsHelpful should pass jslint
Closed, DeclinedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz63219

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
DeclinedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz63219.

Change 121623 had a related patch set uploaded by Siebrand:
Make jslint non-voting for MarkAsHelpful

https://gerrit.wikimedia.org/r/121623

Change 121623 abandoned by Hashar:
Make jslint non-voting for MarkAsHelpful

Reason:
MarkAsHelpful is passing as shown on the two last changes merged in:

https://gerrit.wikimedia.org/r/#/c/58780/
https://gerrit.wikimedia.org/r/#/c/121609/

You probably got hit by https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 which can be solved by added a dummy .jshintrc in the repository that would contain:

{}

https://gerrit.wikimedia.org/r/121623

Closing, per my comment on the Gerrit change.