Page MenuHomePhabricator

checkLess.php doesn't validate skin styles
Closed, ResolvedPublic


checkLess.php does not validate skin styles. This is a general issue, but is especially problematic for mediawiki.ui and mediawiki.ui.button which package all their styles this way (using 'default').

checkLess.php uses ResourceLoaderFileModule's public getAllStyleFiles method, which only uses $this->styles .

Version: 1.23.0
Severity: normal
See Also:



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:02 AM
bzimport set Reference to bz63343.

Change 122838 had a related patch set uploaded by Phuedx:
Make checkLess.php validate skin styles

Change 122838 merged by jenkins-bot:
Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles