Page MenuHomePhabricator

Document "Typography refresh/update" CSS changes for Vector
Closed, ResolvedPublic

Description

Ic5ba836364d04b2c3814777b69b5f47fce25292a , as noted in http://lists.wikimedia.org/pipermail/wikitech-l/2014-March/075498.html, introduced extensive CSS changes, but has no release notes, in total disregard of [[mw:Manual:Coding conventions]]. Unless fixed, the change is liable to immediate revert; at any rate, it can't land in a stable release as is.

We need release notes explaining:

  1. what changed exactly,
  2. why,
  3. how a wiki can be configured to keep the 1.22 styles.

Once done, though it's not on the "coding" mandatory part,

  1. MediaWiki users need to be notified on mediawiki-l,
  2. [[mw:MediaWiki 1.23]] needs to be updated.

Point (1) can perhaps be achieved by distilling the content of [[mw:Typography refresh]], while for (2) we're currently in total lack of rationales (cf. https://www.mediawiki.org/?oldid=945913#Wikipedia_or_MediaWiki.3F) and on (3) I've not heard anything.

On (4), the extensive usage of Wikimedia-only discussion venues, for months, gave the definite impression that this change was planned for Wikimedia projects only, so (unless the change is reverted in core) an energic communication will be needed to compensate and properly notify/involve MediaWiki users.


Version: 1.23.0
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63942

Details

Reference
bz63351

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:03 AM
bzimport set Reference to bz63351.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Apr 1 2014, 7:31 AM

A (very brief) release notes entry was already added in Ic9dc071d. It definitely could use improvement, though.

Reset priority: release notes by definition must be in next release.

That "next release" is 1.23 and three (?) weeks away. Leaving it up to the corresponding developers to judge how fast this will get handled...

(In reply to Andre Klapper from comment #3)

That "next release" is 1.23 and three (?) weeks away. Leaving it up to the
corresponding developers to judge how fast this will get handled...

For now there seems to be consensus that – absent documented, stable decisions on fonts (and the rest?) – the 1.22 status quo should be kept in 1.23.
http://lists.wikimedia.org/pipermail/wikitech-l/2014-April/075907.html

swalling wrote:

(In reply to Nemo from comment #4)

(In reply to Andre Klapper from comment #3)

That "next release" is 1.23 and three (?) weeks away. Leaving it up to the
corresponding developers to judge how fast this will get handled...

For now there seems to be consensus that – absent documented, stable
decisions on fonts (and the rest?) – the 1.22 status quo should be kept in
1.23.
http://lists.wikimedia.org/pipermail/wikitech-l/2014-April/075907.html

You link to one user stating their personal preference, and call it consensus?

(In reply to Steven Walling from comment #5)

You link to one user stating their personal preference, and call it
consensus?

Nobody objected so far.

As of I595feec9, the MediaWiki 1.23 release branch does not include any fonts changes compared to previous releases – everything, text and headings, is just 'sans-serif'.

Someone still needs to document all the other changes to text style.

I don't know where you want them or how detaild they should be, but here are the core changes (that I know of)...

  • Various Vector CSS properties have been converted to LESS variables
  • The font size of #bodyContent/.mw-body-content has been increased to 0.875em
  • The line-height of #bodyContent/.mw-body-content has been increased to 1.6
  • All headers have updated sizes and margins
  • H1 and H2 headers now use a serif font

For now, the body font has been reverted to just sans-serif.

I've copied Erwin's comments to https://www.mediawiki.org/wiki/MediaWiki_1.23#CSS_Refresh_for_Vector and will point to that section in the release notes.

Since the release notes already point to Typography update, I think URL currently in RELEASE-NOTES-1.23 in master + the on-wiki information I just added is sufficient. We'll sync them up before release.

I don't see anything in RELEASE-NOTES-1.23, branch or master.

(In reply to Nemo from comment #11)

I don't see anything in RELEASE-NOTES-1.23, branch or master.

https://git.wikimedia.org/blob/mediawiki%2Fcore.git/20c2b9e4cee296fa1caa1cdcae37d6e883067519/RELEASE-NOTES-1.23#L150 not specific enough?

(In reply to Andre Klapper from comment #12)

not
specific enough?

See comment 0 and 1.

Someone who knows the /exact/ changes, needs to go through
https://www.mediawiki.org/wiki/MediaWiki_1.23#CSS_refresh_for_Vector
and
https://www.mediawiki.org/wiki/Typography_refresh
to update the things that were changed since those docs were written, and add any missing items.
(eg. The FAQ Summary says "The superscript (sup) and subscript (sub) line-heights are now set to 1" but I think that was changed to "0" at some point? and it's not mentioned in the [MediaWiki_1.23] page.

Possibly there are more links that should be added to this list?
https://www.mediawiki.org/wiki/Typography_refresh#Code_links

We want/need details and specifics.

I've made some updates to those pages.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptNov 18 2016, 3:50 PM