Page MenuHomePhabricator

[Story] wikis not removed from wb_changes_dispatch table when removed from localClientDatabases setting
Open, LowPublic

Description

wikis are not removed from wb_changes_dispatch table when they are removed from localClientDatabases setting.

this causes errors to be reported by the dispatcher, such as which pollutes the logs:

ERROR: exception 'MWException' with message 'Wiki not configured: test2wiki; consider removing it from the wb_changes_dispatch'

it would be nicer if Wikibase handled this situation more robustly

Details

Reference
bz63411

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:07 AM
bzimport set Reference to bz63411.
bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Apr 2 2014, 11:59 AM
aude added a comment.Apr 2 2014, 11:59 AM

see bug 63409

aude added a comment.Apr 2 2014, 12:01 PM

this also causes Special:DispatchStats to be skewed and the removed wiki reported as "Stalest"

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
daniel added a subscriber: daniel.Sep 3 2015, 2:08 PM

I'm unsure how to best solve this. We could:

  • automatically remove the old wiki from wb_changes_dispatch. Disadvantage: if you add the wiki back, the dispatcher would then send everything to it, since it no longer knows where it left off.
  • we could just ignore this situation and not log it. Disadvantage: Then the removed wiki would still show up in the stats as most lagged. Also, if we have many removed wikis, they could take up all the "top lagged" slots, leading to the dispatcher never finding a wiki it can dispatch to.
  • we could flag the entry in wb_changes_dispatch as removed. Disadvantage: if you add the wiki back into the config, it would still be ignored until the flag is removed from the database entry.

How often does something like this happen? I'm inclined to think that the cure is worse than the disease... we'd introduce magic that would lead to more inconsistencies. Is manually removing a row from the database really so bad? Wikis are usually not decommissioned that often...

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2015, 2:08 PM
JanZerebecki lowered the priority of this task from Medium to Low.Sep 10 2015, 6:51 PM
JanZerebecki set Security to None.
JanZerebecki moved this task from incoming to needs discussion or investigation on the Wikidata board.
JanZerebecki removed a subscriber: Wikidata-bugs.
Jonas renamed this task from wikis not removed from wb_changes_dispatch table when removed from localClientDatabases setting to [Story] wikis not removed from wb_changes_dispatch table when removed from localClientDatabases setting.Nov 2 2015, 5:12 PM
Jonas added a project: Technical-Debt.
Addshore added a subscriber: Addshore.EditedOct 31 2018, 5:32 PM

Heh, I ran into this again this week on beta in a slightly different form, but the same underlying issue i think T208307: Beta: JobQueueGroup.php: Domain 'specieswiki' is not recognized.

Addshore updated the task description. (Show Details)Oct 31 2018, 5:33 PM