Author: mnewton
Description:
In UploadWizard.config.php options for default licensing types are given as such:
// Possible values: ownwork, thirdparty, choice.
In fact, the page will not work with "ownwork" and gives this error:
TypeError: mw.UploadWizard.config.licensing.ownWork.defaults is undefined
However, it works fine with "ownWork". Presumably the same applies for "thirdParty".
Version: master
Severity: minor
The issue is actually in the mw.UploadWizardDeedOwnWork.js file:
defaultLicense = config.licensing.ownWork.defaults[ 0 ];
In UploadWizard.config.php, there is no "defaults" key for "ownWork".
Change 261170 had a related patch set uploaded (by PranavK):
UploadWizard's "ownwork" and "thirdparty" are case sensitive
Thanks @Pranavmk98! Indeed the task description was wrong about what the real problem was. Sorry about the messy GCI task, and great work in resolving it anyway :)
Change 261170 merged by jenkins-bot:
Define required 'defaults' field in licensing config
This caused T123840, reverted in https://gerrit.wikimedia.org/r/264578 :(
@Tgr pointed out in code review on the original patch how it's really
silly that this field is an array when only the first value is used.
Turns out that CampaignSchema actually specifies it as a string,
and will prevent Campaign pages from being saved when it's an array...
On the bright side, that means it was actually impossible to use in
campaigns (when defined as an array, validation would fail and not
save the page; when defined as a string, UploadWizard would throw
exceptions), so we'll be able to correct the code to use it as a string
without breaking changes.
Change 264697 had a related patch set uploaded (by Bartosz Dziewoński):
Define required 'defaults' field in licensing config, correct the code using it
Change 264697 merged by jenkins-bot:
Define required 'defaults' field in licensing config, correct the code using it