Page MenuHomePhabricator

Consolidate code for MediaViewer across desktop and mobile
Open, MediumPublic

Description

Desktop and mobile use different implementations for displaying a lightbox when images are clicked.
There is lots of user value e.g. performance/functionality to consolidating these two experiences.

Pros of desktop version compared to mobile

  • Has support for 3d images

Cons of desktop version compare

  • ~100KB of code (minified, decompressed). Mobile uses ~5KB

Cons of both

  • Desktop built in OOUI library (rather than Codex)
  • Mobile uses non-standard MobileFrontend library (rather than Codex)

Benefits of consolidating the two experiences

  • One less unmaintained extension in our deployed servers
  • More functionality to mobile users
  • better frontend performance for desktop users

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
DeclinedNone
OpenJdlrobson
OpenNone
DeclinedNone
ResolvedTheDJ
DeclinedNone
ResolvedJdlrobson
Resolved bmansurov
DeclinedNone
ResolvedJdlrobson
InvalidNone
Duplicate Nirzar
OpenNone
ResolvedJdlrobson
DeclinedNone
Resolved Esanders
Resolved Esanders
Resolvedmatmarex
Resolvedmatmarex
Resolvedovasileva
ResolvedABorbaWMF
ResolvedNone
DuplicateNone
DuplicateNone
ResolvedJdlrobson
ResolvedTheDJ
ResolvedTheDJ
DeclinedNone
OpenNone
OpenNone
ResolvedBUG REPORTTheDJ
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
This comment was removed by Tgr.
Nemo_bis renamed this task from [Tracking] Consolidate code for MediaViewer across desktop and mobile to Consolidate code for MediaViewer across desktop and mobile (tracking).Jul 19 2015, 9:59 AM
Nemo_bis updated the task description. (Show Details)
Jhernandez subscribed.

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

cc @JKatzWMF and @Nirzar
If we want to add things like 3d support to the mobile experience this work should be prioritised and the mediaviewer inside MobileFrontend should be removed. Ideally, we should not have to support two experiences for viewing media files.

Jdlrobson renamed this task from Consolidate code for MediaViewer across desktop and mobile (tracking) to Consolidate code for MediaViewer across desktop and mobile.Mar 22 2023, 11:50 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Change #1032011 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/MultimediaViewer@master] Remove the thumbnail blurring

https://gerrit.wikimedia.org/r/1032011

Change #1032011 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Remove the thumbnail blurring

https://gerrit.wikimedia.org/r/1032011