Page MenuHomePhabricator
Create Task
Maniphest T65504

Consolidate code for MediaViewer across desktop and mobile
Open, MediumPublic
Actions

Description

Desktop and mobile use different implementations for displaying a lightbox when images are clicked.
There is lots of user value e.g. performance/functionality to consolidating these two experiences.

Pros of desktop version compared to mobile

  • Has support for 3d images

Cons of desktop version compare

  • ~100KB of code (minified, decompressed). Mobile uses ~5KB

Cons of both

  • Desktop built in OOUI library (rather than Codex)
  • Mobile uses non-standard MobileFrontend library (rather than Codex)

Benefits of consolidating the two experiences

  • One less unmaintained extension in our deployed servers
  • More functionality to mobile users
  • better frontend performance for desktop users

Details

Reference
bz63504

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT106267 mobile phone wikitext editor should have edit toolbar
 OpenNoneT106266 Provide a "signature" button in the mobile wikitext editor
 OpenNoneT171974 Improve and consolidate our unified editing platform so that it's great on all devices
 OpenNoneT159971 Provide the VE wikitext editing mode as the mobile wikitext editor
 DuplicateNoneT95952 [Epic] Merge OOJS UI and MobileFrontend View code
 OpenNoneT158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
 DeclinedNoneT144571 Mobile Media Viewer violates user settings
 OpenNoneT65504 Consolidate code for MediaViewer across desktop and mobile
 OpenNoneT77349 Reduce Javascript Code Size per Mobile Team recommendation
 OpenNoneT77368 Enable full-screen mode on tablets
 OpenNoneT66096 Open in media viewer icon renders over text on android browser
 DeclinedNoneT96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
 Resolved• JdlrobsonT87253 Create Anchor abstraction
 ResolvedbmansurovT87254 Create button abstraction
 DeclinedNoneT87255 Create input abstraction
 Resolved• JdlrobsonT73181 [Tracking] MobileFrontend should use mw-ui-icon
 InvalidNoneT74653 Issues with icons in alpha. Get fixed so we can move it to beta.
 Duplicate• NirzarT95224 Update all PNG icons in MobileFrontend with SVGs
 OpenNoneT96186 [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
 Resolved• JdlrobsonT86366 Revisit box-sizing: border-box for everything in MobileFrontend
 DeclinedNoneT88559 VisualEditorOverlay should be written as an OO.ui.ProcessDialog
 ResolvedEsandersT96187 Rewrite VisualEditorOverlay header using OOjs UI
 ResolvedEsandersT96188 Rewrite the edit summary screen of VisualEditorOverlay in OOjs UI
ResolvedmatmarexT198765 Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop)
 ResolvedmatmarexT202978 Move MobileFrontend's VisualEditor styles back to MobileFrontend
 ResolvedovasilevaT205382 Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)
 ResolvedABorbaWMFT208514 Merge PageIssues Feature Branch to Master
 ResolvedNoneT206178 Feature branch: Remove pageIssues A-B test code
 DuplicateNoneT101276 Overlays should support multiple screens
 DuplicateNoneT104008 Have a consistent way of doing Views within Views
 Resolved• JdlrobsonT125471 Remove Class from MobileFrontend and use OOJS for class inheritance

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:12 AM
• bzimport added projects: Don't use – MobileFrontend-Hygiene, Tracking-Neverending.
• bzimport set Reference to bz63504.
• Jdlrobson created this task.Apr 3 2014, 10:16 PM
• bzimport added a comment.Nov 19 2014, 5:45 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/KdBttENl

Jdforrester-WMF edited projects, added Technical-Debt, MobileFrontend-General-or-Unknown; removed Don't use – MobileFrontend-Hygiene.Dec 8 2014, 9:42 PM
• Jdlrobson updated the task description. (Show Details)Dec 9 2014, 11:45 PM
• Jdlrobson edited projects, added Readers-Web-Backlog, MediaViewer; removed MobileFrontend-General-or-Unknown.
• Jdlrobson set Security to None.
• Jdlrobson moved this task from Incoming to 2016-17 Q4 on the Readers-Web-Backlog board.Dec 10 2014, 12:14 AM
Tgr added subtasks: T77349: Reduce Javascript Code Size per Mobile Team recommendation, T77368: Enable full-screen mode on tablets.Dec 11 2014, 1:43 AM
Tgr added a subtask: T77180: Mobile Version of Media Viewer.Dec 11 2014, 2:27 AM
Tgr added a subtask: T66096: Open in media viewer icon renders over text on android browser.Dec 11 2014, 2:58 AM
• Gilles added a project: Multimedia.Dec 15 2014, 8:55 AM
Tgr merged a task: T77180: Mobile Version of Media Viewer.Jan 5 2015, 7:28 PM
Tgr added subscribers: Aklapper, Tgr, MingleTerminator.
Tgr added a comment.Jan 5 2015, 7:30 PM
This comment was removed by Tgr.
Tgr added a project: Mobile.Jan 5 2015, 7:33 PM
• Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Jan 21 2015, 12:00 AM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Jan 30 2015, 12:24 PM
• Jdlrobson moved this task from 2016-17 Q4 to Triaged but Future on the Readers-Web-Backlog board.Apr 10 2015, 6:11 PM
• Jdlrobson added a subtask: T96202: [EPIC] Rewrite MobileFrontend frontend code in OOUI.Apr 16 2015, 12:18 AM
• Jdlrobson moved this task from Triaged but Future to 2016-17 Q1 on the Readers-Web-Backlog board.
kaldari removed a subtask: T77180: Mobile Version of Media Viewer.May 15 2015, 10:56 PM
Nemo_bis renamed this task from [Tracking] Consolidate code for MediaViewer across desktop and mobile to Consolidate code for MediaViewer across desktop and mobile (tracking).Jul 19 2015, 9:59 AM
Nemo_bis updated the task description. (Show Details)
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 19 2015, 9:59 AM
• Jhernandez triaged this task as Medium priority.Aug 18 2015, 5:33 PM
• Jhernandez added a subscriber: • Jhernandez.
• Jhernandez edited projects, added MobileFrontend; removed Readers-Web-Backlog.Aug 18 2015, 5:36 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:27 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Sep 21 2015, 3:44 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 3:53 PM
• Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Nov 4 2015, 5:28 PM
• Jdlrobson moved this task from Team:Growth to team:other on the MobileFrontend board.Feb 18 2016, 6:43 PM
MBinder_WMF added a project: Readers-Web-Backlog.May 17 2016, 6:35 PM
• Jdlrobson moved this task from 2016-17 Q1 to Incoming on the Readers-Web-Backlog board.May 18 2016, 3:35 PM
• Jdlrobson moved this task from Incoming to Epics/Goals on the Readers-Web-Backlog board.May 25 2016, 9:56 PM
Jdforrester-WMF removed a subscriber: Jdforrester-WMF.Jul 5 2016, 9:27 AM
Quiddity removed a parent task: T4007: [DO NOT USE] Tracking bug [superseded by #Tracking].Jul 14 2016, 4:13 AM
brion added a parent task: T158181: Aim for workflow equivalence for MediaWiki on desktop and mobile web.Feb 15 2017, 1:45 PM
MBinder_WMF removed a project: Readers-Web-Backlog.Apr 13 2017, 6:40 PM
• Jdlrobson added a project: Readers-Web-Backlog.Apr 13 2017, 9:13 PM
• Jdlrobson moved this task from Epics/Goals to 2014-15 Q4 on the Readers-Web-Backlog board.

One exception to the rule :)

• Jdlrobson added subscribers: • Nirzar, • JKatzWMF.Apr 26 2017, 8:16 PM

cc @JKatzWMF and @Nirzar
If we want to add things like 3d support to the mobile experience this work should be prioritised and the mediaviewer inside MobileFrontend should be removed. Ideally, we should not have to support two experiences for viewing media files.

MarkTraceur moved this task from Backlog to Next on the MediaViewer board.Apr 27 2017, 3:41 PM
• Jhernandez removed a subscriber: • Jhernandez.Jun 26 2017, 2:55 PM
• Jdlrobson mentioned this in T144571: Mobile Media Viewer violates user settings.Jun 27 2017, 8:29 PM
• Jdlrobson moved this task from 2014-15 Q4 to Tracking on the Readers-Web-Backlog board.Jun 29 2017, 8:20 PM
• Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.
• Jdlrobson moved this task from Untriaged to Move to Backlog on the Readers-Web-Backlog (Tracking) board.
MBinder_WMF added a project: Multimedia.Aug 7 2017, 5:39 PM
• Ramsey-WMF moved this task from Backlog to Desired epics on the Multimedia board.Oct 13 2017, 11:44 PM
CKoerner_WMF added a subscriber: CKoerner_WMF.Feb 12 2018, 8:42 PM
• Jdlrobson removed • Jdlrobson as the assignee of this task.Aug 16 2018, 3:40 PM
• Jdlrobson edited projects, added Readers-Web-Backlog; removed Multimedia, Readers-Web-Backlog (Tracking).
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 16 2018, 3:40 PM
• Jdlrobson moved this task from Incoming to Tracking on the Readers-Web-Backlog board.Aug 16 2018, 5:22 PM
• Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.
• JKatzWMF removed a subscriber: • JKatzWMF.Sep 4 2018, 4:30 PM
Liuxinyu970226 awarded a token.Nov 11 2018, 12:49 PM
Tgr removed a subscriber: Tgr.Jul 9 2019, 6:03 PM
• Jdlrobson closed subtask T96202: [EPIC] Rewrite MobileFrontend frontend code in OOUI as Declined.Aug 2 2019, 5:00 PM
CKoerner_WMF removed a subscriber: CKoerner_WMF.Dec 12 2019, 4:22 PM
• Jdlrobson moved this task from team:other to Tracking on the MobileFrontend board.Jul 24 2020, 2:40 AM
• Jdlrobson edited projects, added MobileFrontend (Tracking); removed MobileFrontend.
Aklapper edited projects, added Epic; removed Tracking-Neverending.Aug 15 2020, 2:59 PM
Aklapper added a parent task: T144571: Mobile Media Viewer violates user settings.
• Jdlrobson moved this task from Move to Backlog to Untriaged on the Readers-Web-Backlog (Tracking) board.Sep 7 2021, 9:06 PM
• Jdlrobson edited projects, added Readers-Web-Backlog (Needs Prioritization (Tech)); removed Readers-Web-Backlog (Tracking).Sep 21 2021, 8:29 PM
• Jdlrobson moved this task from Backlog to Future Unplanned on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.Sep 22 2021, 3:00 PM
• Jdlrobson moved this task from Future Unplanned to Tracking Indefinitely on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.Nov 4 2021, 8:50 PM
• Jdlrobson merged a task: T220558: ImageGateway should utilize browser cache when calling MediaWIki API.Nov 5 2021, 12:04 AM
• Jdlrobson added subscribers: • nray, phuedx, Niedzielski, pmiazga.
• Jdlrobson removed a project: Readers-Web-Backlog (Needs Prioritization (Tech)).Dec 9 2021, 5:41 PM
Aklapper moved this task from Next to Backlog on the MediaViewer board.Mar 16 2022, 11:34 AM
• Jdlrobson added a project: Readers-Web-Backlog.Mar 22 2023, 11:46 PM
• Jdlrobson renamed this task from Consolidate code for MediaViewer across desktop and mobile (tracking) to Consolidate code for MediaViewer across desktop and mobile.Mar 22 2023, 11:50 PM
• Jdlrobson updated the task description. (Show Details)
• Jdlrobson mentioned this in T235796: The ext.3d.styles module should not be added unconditionally to every page and should set target mobile.
• Jdlrobson updated the task description. (Show Details)
• Jdlrobson moved this task from Incoming to Epics/Goals on the Readers-Web-Backlog board.Apr 6 2023, 5:56 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL