Page MenuHomePhabricator

AbuseFilter *_links variables incorrect on item edits.
Open, LowPublic

Description

The AbuseFilter variables added_links and removed_links don't seem to work (are always empty), also all_links seems to equal old_links. This is Wikibase specific, as it works with wikitext pages.


See Also:
T65255: check standard spam prevention features work in Wikibase

Details

Reference
bz63632

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:21 AM
bzimport set Reference to bz63632.
bzimport added a subscriber: Unknown Object (MLST).
hoo created this task.Apr 7 2014, 3:39 PM
hoo added a comment.May 4 2014, 8:25 PM

This can be fixed by either making Wikibase hook into AbuseFilter's "AbuseFilter-interceptVariable" hook (that might get messy). Or by doing some more work on ContentHandler support in AbuseFilter (which is also going to be a pain, given the way AbuseFilter "works").

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

Is this still relevant?

Lydia_Pintscher lowered the priority of this task from High to Low.Apr 23 2017, 2:53 PM
matej_suchanek removed a subscriber: Wikidata-bugs.

Sadly, yes.

Daimona added a subscriber: Daimona.EditedAug 23 2019, 11:20 AM

I'm sorry, I'm pretty ignorant about wikidata. How exactly am I supposed to reproduce the problem? I tried here, but I'm unsure if that's right. If it is, then indeed we don't get _links variables.

Update: well, TBH I see some checks for ContentModel === Wikitext in the code used to retrieve links...