Page MenuHomePhabricator
Create Task
Maniphest T65651

VisualEditor: Double clicking nodes should open them, but it's not working for hieroglyphics
Closed, ResolvedPublic
Actions

Description

This is related to bug 50996.

Open a page that contains hieroglyphics, like https://www.mediawiki.org/w/index.php?oldid=942532#Hieroglyphics

You should be able to open the hieroglyphics "node" by double-clicking, but it isn't working.

Version: unspecified
Severity: normal

Details

Reference
bz63651

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:22 AM
• bzimport added projects: VE-deploy-2014-04-10, VisualEditor-EditingTools.
• bzimport set Reference to bz63651.
• Whatamidoing-WMF created this task.Apr 7 2014, 8:48 PM
Catrope added a comment.Apr 7 2014, 8:50 PM

I think Trevor fixed this in an unrelated recent commit, let me find it.

Catrope added a comment.Apr 7 2014, 8:51 PM

https://gerrit.wikimedia.org/r/#/c/121514/

gerritbot added a comment.Apr 7 2014, 9:45 PM

Change 124469 had a related patch set uploaded by Catrope:
Actually actually fix double-clicking on hieroglyphics nodes

https://gerrit.wikimedia.org/r/124469

gerritbot added a comment.Apr 8 2014, 7:29 PM

Change 124469 merged by jenkins-bot:
Actually actually fix double-clicking on hieroglyphics nodes

https://gerrit.wikimedia.org/r/124469

Ryasmeen added a comment.Apr 9 2014, 8:16 PM

Verified the fix on betalabs

Ryasmeen added a comment.Apr 14 2014, 10:13 PM

Verified the fix in test2

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:08 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL