Page MenuHomePhabricator

Flow: display, behavior, and API failures when displaying a post revision
Open, MediumPublic


You can display a particular revision of a post in Flow, e.g. in topic actions, choose History, then click the timestamp under a post activity.

There are several glitches with this.

  • Three horizontal lines at top is overkill: <Topic title> -------------------------------------------- This topic was started on <Flow board> -------------------------------------------- This is a permanent link to the first version of this post. You can view later versions on the post history page. --------------------------------------------
  • It's not clear you're only viewing one post from the topic.
  • It shouldn't say "You can view later versions on the post history page" if the first version is the only version.
  • If you choose Permalink from the revision's action menu, you get a link to latest revision, not this one (which you're already viewing)
  • If you Hide are you hiding just this version? I tried it and got a pink API error box, the 500 response contains PHP fatal error in /usr/local/apache/common-local/php-1.23wmf21/extensions/Flow/includes/WorkflowLoader.php line 107: <br/> Argument 1 passed to Flow\WorkflowLoader::loadWorkflow() must be an instance of Title, boolean given, called in /usr/local/apache/common-local/php-1.23wmf21/extensions/Flow/includes/WorkflowLoader.php on line 85 and defined
  • Suppressing the particular version you see might make sense, I don't know if it does that.
  • It has Reply • Edit • Thank.
    • Reply doesn't make sense, you don't want to reply to an old version that says "X is Y" when the latest version says "X is ABC".
    • Edit goes and edits the latest version, which is a little confusing.
    • I don't think Thanks generates a link to the version for which you're thanking.

If you are viewing the latest version of a post these could all be enabled, but it's still confusing, and how would the Thanks extension know when this is the case?

We should spec out what you should be able to do when viewing an older version of a post. Reducing or eliminating Action menu and flow-post-action menu items would reduce the scope for these errors.

Version: master
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:07 AM
bzimport set Reference to bz63696.
bzimport added a subscriber: Unknown Object (MLST).
Spage created this task.Apr 8 2014, 7:32 PM

The API failure I mention above (when you Hide/Unhide from the display of a post revision) occurs because the workflow parameter is missing from the API request. But before fixing this we should decide if it even makes sense to offer the operation.

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:42 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 29 2015, 7:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2015, 5:23 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 6:44 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 6:03 PM