Page MenuHomePhabricator

Large number of CSS rules for external links
Open, NormalPublic

Description

  1. Wikimedia wikis{{which}} have{{citation needed}} a large{{vague}} number of CSS rules for external links (icons);
  2. this is a problem{{vague}}, also for performance.{{citation needed}}

Hoo (or another shell user), can you please help us verify (1) by running [[wikitech:mwgrep]]? "mwgrep external" may be enough; if it's too noisy, I guess [[MediaWiki:Common.css]] can give suggestions as well.

Discussing (2) is out of scope for this bug: go to bug 54604 instead for that.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54604

Details

Reference
bz63725

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:09 AM
bzimport set Reference to bz63725.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Apr 9 2014, 1:01 PM
hoo added a comment.Apr 9 2014, 1:43 PM

Created attachment 15066
Output of: mwgrep external --max-results 1000 | grep '.css$'

Attached:

(In reply to Nemo from comment #0)

  1. Wikimedia wikis{{which}} have{{citation needed}} a large{{vague}} number

of CSS rules for external links (icons);

  1. this is a problem{{vague}}, also for performance.{{citation needed}}

Hoo (or another shell user), can you please help us verify (1) by running
[[wikitech:mwgrep]]? "mwgrep external" may be enough; if it's too noisy, I
guess [[MediaWiki:Common.css]] can give suggestions as well.
Discussing (2) is out of scope for this bug: go to bug 54604 instead for
that.

My reading of the other bug is a complaint about css rules in core mediawiki skin files, not css rules in wiki css.

(In reply to Bawolff (Brian Wolff) from comment #2)

My reading of the other bug is a complaint about css rules in core mediawiki
skin files, not css rules in wiki css.

Sure, that's why I filed a separate one for Wikimedia wikis. :) Or are you saying that such CSS rules are more efficient when placed in wiki CSS?

(In reply to Nemo from comment #3)

(In reply to Bawolff (Brian Wolff) from comment #2)

My reading of the other bug is a complaint about css rules in core mediawiki
skin files, not css rules in wiki css.

Sure, that's why I filed a separate one for Wikimedia wikis. :) Or are you
saying that such CSS rules are more efficient when placed in wiki CSS?

Oh. Sorry I misunderstood why you were filing this. Carry on. :)

(I take no position on the css link rule thing. I honestly have no idea. Somebody should probably profile it (is there profiling tools for css? I dont even know). Premature optimization is the root of all evil and all that)

(In reply to Marius Hoch from comment #1)

Created attachment 15066 [details]
Output of: mwgrep external --max-results 1000 | grep '.css$'

Oh well, that's a juniper thicket in any case (we'd say in Italian); I sent them all a notice and they'll decide what to do if anything.
https://meta.wikimedia.org/w/index.php?title=Special:Log/massmessage&dir=prev&offset=20140408175303&limit=1&type=massmessage&user=
Now let's listen. :)

Attached: