| Tgr | |
| Apr 11 2014, 11:04 PM |
| F13818: oojsui-textbox-no-shadow.png | |
| Nov 22 2014, 3:17 AM |
| F13817: oojsui-textbox-shadow.png | |
| Nov 22 2014, 3:17 AM |
OOjs UI adds a white text shadow to the TextInputWidget. This is normally invisible (since it's on a white background) but looks very ugly on Chrome on Linux when the text is selected, since selected text has white color and the shadow distorts the characters. Seen on Chrome 33 on Ubuntu 13.10, in the Use this file > Embed > HTML menu in MediaViewer.
Version: unspecified
Severity: trivial
OS: Linux
Platform: PC
Created attachment 15087
TextInputWidget with selected text, with text-shadow disabled
Attached:
I got confused for a bit trying to reproduce this. Turns out it only happens for readonly and disabled TextInputWidgets.
So I had a chat with Trevor and we decided that the text shadow should be removed for readonly TextInputWidgets (like the examples in your screenshot). It makes no sense because it's a white shadow on a white background anyway, so you can't even see it unless you're selecting.
For disabled TextInputWidgets, we do want to keep the white shadow to make the gray text on a gray background stand out. We considered unsetting the shadow when selecting, but selection of text in a disabled input 1) sounds like it shouldn't be possible, 2) doesn't appear to be detectable and 3) is implemented inconsistently in browsers (I played with it in Firefox and it was HAUNTED)
Change 171030 had a related patch set uploaded by SuchetaG:
Removing text-shadow from readonly/disabled text in TextInputWidget
Change 171030 merged by jenkins-bot:
Removing text-shadow from readonly/disabled text in TextInputWidget
