Page MenuHomePhabricator

GlobeCoordinateValue.precision is allowed to be null but validated as not null
Closed, InvalidPublic

Description

Author: christian.dullweber

Description:
WikibaseDataTypeBuilders::buildCoordinateType creates a validator for precision that only accepts float and integer but there are Item with precision=null and the GlobeCoordinateValue allows precision to be null.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference
bz64048

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:13 AM
bzimport set Reference to bz64048.
bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
thiemowmde lowered the priority of this task from Medium to Lowest.

Said validator is still in place in ValidatorBuilders::buildCoordinateValidators.

The fact that a validator applies more restrictions than the data type implementation is not surprising. This is basically the point of having separate validators. For example, string values are restricted in length even if the StringValue type does not have any length limitation. Similar for calendar models, globes, and precisions.

I'm closing this ticket for now because it does not describe a use-case that is actually broken, an expected behavior, or something. Is the issue that there are null values in the wikidata.org database? Are there actual requests to add this nullable feature to the UI?

Not long ago I worked on the UI portion of this issue as part of T109455, see https://gerrit.wikimedia.org/r/279398.