Page MenuHomePhabricator
Create Task
Maniphest T66065

Hovercards throws error on Special:MyLanguage links
Closed, ResolvedPublic
Actions

Description

Hovercards throws a JavaScript error when hovering on a link using Special:MyLanguage

Steps to reproduce:
*Go to https://commons.wikimedia.org/wiki/Commons:Upload_tools
*Hover on any link (eg Upload Wizard)
*Error is thrown in notif:

Error: https://bits.wikimedia.org/commons.wikimedia.org/load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140417T030828Z at line 0: Script error.

This may be the case with all Special: pages (as on the same page, Special:Preferences fails too), but as a user I expect Hovercards to work on MyLanguage pages, since they are topical pages.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63045
https://bugzilla.wikimedia.org/show_bug.cgi?id=64522

Details

Reference
bz64065

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:14 AM
• bzimport added a project: Page-Previews.
• bzimport set Reference to bz64065.
JeanFred created this task.Apr 17 2014, 4:35 PM
• Prtksxna added a comment.Apr 18 2014, 2:10 PM

Thanks for pointing this out Jean!

The error occurs when the extension tries to obtain a timestamp for the special page (which does not exist).

Uncaught TypeError: Cannot read property '0' of undefined
at line 69 of ext.popups.core.js

gerritbot added a comment.Apr 22 2014, 9:45 AM

Change 127889 had a related patch set uploaded by Prtksxna:
Check if revisions exist before getting a timestamp

https://gerrit.wikimedia.org/r/127889

• Prtksxna added a comment.Apr 22 2014, 10:32 AM

Max, does TextExtracts return anything for Special pages anyway?

gerritbot added a comment.Apr 28 2014, 11:08 AM

Change 127889 abandoned by Prtksxna:
Check if revisions exist before getting a timestamp

Reason:
Rebase hell.

https://gerrit.wikimedia.org/r/127889

gerritbot added a comment.Apr 28 2014, 11:30 AM

Change 130058 had a related patch set uploaded by Prtksxna:
Don't show popups if the page does not have the .extract property

https://gerrit.wikimedia.org/r/130058

gerritbot added a comment.May 1 2014, 5:17 AM

Change 130058 abandoned by Prtksxna:
Don't show popups if the page does not have the .extract property

Reason:
Part of the restructure

https://gerrit.wikimedia.org/r/130058

• Prtksxna moved this task from Backlog to Archive on the Page-Previews board.Dec 3 2014, 5:28 AM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL