Page MenuHomePhabricator

PHP Notice on Special:Version with Scribunto enabled
Closed, ResolvedPublic

Description

Undefined offset: 0 in core/includes/specials/SpecialVersion.php on line 968

Only appears with Scribunto enabled. Disabling scribunto makes it go away


Version: unspecified
Severity: minor

Details

Reference
bz64069

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:15 AM
bzimport set Reference to bz64069.
bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Apr 17 2014, 6:26 PM
Reedy added a comment.Apr 17 2014, 6:42 PM

array(1) {

["scribunto"]=>
string(28) "ScribuntoHooks::reportLimits"

}

string(77) "SpecialVersion::execute/SpecialVersion::getWgHooks/SpecialVersion::listToText"

Reedy added a comment.Apr 17 2014, 6:48 PM

$wgHooks['ParserLimitReport']['scribunto'] = 'ScribuntoHooks::reportLimits';

Change 127031 had a related patch set uploaded by Reedy:
Fix PHP Notice on Special:Version with Scribunto enabled

https://gerrit.wikimedia.org/r/127031

Change 127115 had a related patch set uploaded by Reedy:
Simplify SpecialVersion:listToText()

https://gerrit.wikimedia.org/r/127115

Reedy added a comment.Apr 17 2014, 9:08 PM

Needs $wgSpecialVersionShowHooks to be set to true to replicate

Change 127031 abandoned by Anomie:
Fix PHP Notice on Special:Version with Scribunto enabled

Reason:
Per Reedy's comment that this should be abandoned if this is done purposefully.

https://gerrit.wikimedia.org/r/127031

Change 127115 merged by jenkins-bot:
Simplify SpecialVersion:listToText()

https://gerrit.wikimedia.org/r/127115

Confirmed that Gerrit change 127115 is sufficient to fix the issue.