Page MenuHomePhabricator

Search bar title autocompletion no longer expands width as necessary
Closed, ResolvedPublic

Description

How it should be: https://commons.wikimedia.org/wiki/File:MediaWiki_1.22.5_search_autocomplete.png
How it is: https://commons.wikimedia.org/wiki/File:MediaWiki_search_autocomplete.png

17.46 < MatmaRex> Nemo_bis: huh, that's a bug, it's supposed to expand to up to 3x the normal width if necessary

Reported at https://it.wikipedia.org/wiki/Wikipedia:Bar/Discussioni/Ricerca_e_autocompletamento ; probably byproduct of the fixes for bug 59172.


Version: 1.23.0
Severity: major
URL: https://commons.wikimedia.org/wiki/File:MediaWiki_search_autocomplete.png
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=65224

Details

Reference
bz64093

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz64093.
Nemo_bis created this task.Apr 18 2014, 3:50 PM

I'm somewhat relieved to see I search bug I probably didn't cause.

Change 127355 had a related patch set uploaded by Bartosz Dziewoński:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127355

Change 127355 merged by jenkins-bot:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127355

Change 127471 had a related patch set uploaded by Nemo bis:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127471

Verified working on beta.

Change 127472 had a related patch set uploaded by Nemo bis:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127472

Change 127473 had a related patch set uploaded by Nemo bis:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127473

Backported to 1.23 release.

Change 127471 merged by jenkins-bot:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127471

Change 127472 merged by Catrope:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127472

Change 127473 merged by Catrope:
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

https://gerrit.wikimedia.org/r/127473

Approved and deployed by Roan (pinged by MatmaRex), verified working on it.wiki. Thanks!

(Canceling backport request because I can't set it to granted... Anyway the flag didn't help here.)

I have one report from one user that this bug is still not fixed for him.
https://it.wikipedia.org/?diff=65832029&oldid=65554079
I only managed to discover that he uses Internet Explorer, no idea of version/OS/screenshots.

Yeah, that's probably bug 65224, which apparently affects all IE versions
from 6 through 11. As far as I can tell the code is correct now, but it doesn't work on IE; I haven't yet had the time to investigate why.

There is also a slightly related patch at https://gerrit.wikimedia.org/r/127358 which will enable standard tooltips for the autocompletion list entries (full page title in the 'title' attribute, displayed as a tooltip on hover) which will make the IE bug less problematic if it's merged.