Page MenuHomePhabricator
Create Task
Maniphest T66199

VisualEditor: [Regression] Only most recently added parameter gets trash can icon in citation dialog
Closed, ResolvedPublic
Actions

Description

Before applying the changes

Steps to reproduce:

1.Open a page with VE
2.Go to Cite>Website/Book/Newspaper/Journal
3.Add some optional parameters from the parameter list
4.Also add the parameter URL as an optional parameter
5.Apply changes

Observed Result:
Observe that, before applying changes the parameter URL does not have a trash icon beside but the other optional parameter does.But, after applying the changes , the trash icon does appear for the parameter URL but not for the other one.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser:: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/wiki/21staprilchrome?veaction=edit

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-04-21_at_12.19.00_PM.png (487×678 px, 43 KB)

Details

Reference
bz64199

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:23 AM
• bzimport added projects: VE-deploy-2014-04-24, VisualEditor-EditingTools.
• bzimport set Reference to bz64199.
Ryasmeen created this task.Apr 21 2014, 7:21 PM
Ryasmeen added a comment.Apr 21 2014, 7:25 PM

Created attachment 15151
After applying changes

Attached:

Screen_Shot_2014-04-21_at_12.25.07_PM.png (476×632 px, 40 KB)

Catrope added a comment.Apr 21 2014, 8:32 PM

It seems that the logic here is that:

  • When creating a new citation, none of the default parameters can be removed
  • When inspecting an existing citation, only the first (topmost) parameter can be removed
  • After adding a new parameter, only that parameter can be removed
Catrope added a comment.Apr 21 2014, 8:35 PM

This is only broken in the citation inspector, it works fine in the template inspector.

gerritbot added a comment.Apr 24 2014, 12:36 AM

Change 129344 had a related patch set uploaded by Trevor Parscal:
Make citation dialog display like transclusion dialog in single mode

https://gerrit.wikimedia.org/r/129344

gerritbot added a comment.Apr 24 2014, 1:09 AM

Change 129344 merged by jenkins-bot:
Make citation dialog display like transclusion dialog in single mode

https://gerrit.wikimedia.org/r/129344

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:06 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL