Page MenuHomePhabricator

VisualEditor: [Regression] Only most recently added parameter gets trash can icon in citation dialog
Closed, ResolvedPublic

Description

Before applying the changes

Steps to reproduce:

1.Open a page with VE
2.Go to Cite>Website/Book/Newspaper/Journal
3.Add some optional parameters from the parameter list
4.Also add the parameter URL as an optional parameter
5.Apply changes

Observed Result:
Observe that, before applying changes the parameter URL does not have a trash icon beside but the other optional parameter does.But, after applying the changes , the trash icon does appear for the parameter URL but not for the other one.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser:: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/wiki/21staprilchrome?veaction=edit


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz64199

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:23 AM
bzimport set Reference to bz64199.
Ryasmeen created this task.Apr 21 2014, 7:21 PM

Created attachment 15151
After applying changes

Attached:

It seems that the logic here is that:

  • When creating a new citation, none of the default parameters can be removed
  • When inspecting an existing citation, only the first (topmost) parameter can be removed
  • After adding a new parameter, only that parameter can be removed

This is only broken in the citation inspector, it works fine in the template inspector.

Change 129344 had a related patch set uploaded by Trevor Parscal:
Make citation dialog display like transclusion dialog in single mode

https://gerrit.wikimedia.org/r/129344

Change 129344 merged by jenkins-bot:
Make citation dialog display like transclusion dialog in single mode

https://gerrit.wikimedia.org/r/129344