Page MenuHomePhabricator

Warns about nonexistent edit conflicts
Open, HighPublic

Description

Not sure if related to bug 55392.
IP user on it.wp reports what follows:
he edited https://it.wikipedia.org/w/index.php?title=Citt%C3%A0_d%27Italia&action=history multiple times.

First edit, an edit conflict notice came up.
He tried to solve that, but there were no actual differences. At that point, although he didn't save, he noticed his edit had already been saved in the history.
Second edit, nothing to report.
Third edit, same thing as the first one.

Firefox 28.0, Win7, Vector.

I didn't try to reproduce.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849

Details

Reference
bz64237

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:08 AM
bzimport set Reference to bz64237.
bzimport added a subscriber: Unknown Object (MLST).
Elitre created this task.Apr 22 2014, 12:59 PM

I think (hope) that this was fixed in the fixes to edit conflict code a few weeks ago.

I got this issue today again, while I was trying to add a new section in edit source mode.But could not reproduce it later.But this is the second time I experienced this issue following the same steps.

Created attachment 15537
Screenshot

Again, reproduced on test2, screenshot attached.Reopening the bug.

Attached:

In edit source mode? Is this a VE bug?

Yes, the edit conflict warning appears in the edit source mode , not in VE .

Okay, I will move this to the MediaWiki product of BZ then.

Copying in Adam who was active in this code area recently – ideas about a regression?

This would be the first I've heard of a new regression. I've tried to leave the edit conflict code functionally unchanged with my recent patches, and the first report predates any work I've done.

I do know there are lots of unpleasant ways that edit conflicts can fail at the moment, silently losing changes being the worst. The reported conflict behavior doesn't sound familiar however, so I'll leave this bug open.

Currently, I'm focusing on adding log instrumentation so that we are able to better diagnose this sort of thing.

This happens to me everyday atleast once in a new login session, when I first time try to save something from Edit Source mode.

We probably need a tracking bug for edit conflicts issues here.

Who does a tracking bug exactly help and which problem does it solve?
Why is searching for "edit conflict" not sufficient?

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2015, 7:54 AM
Zazpot added a subscriber: Zazpot.May 30 2017, 4:17 AM

https://en.wikipedia.org/w/index.php?title=Feh_%28image_viewer%29&action=edit&undoafter=767731611&undo=782915510 produces an error message claiming that an edit conflict exists.

However, the only later edit to the article was on a different line, so how can an edit conflict exist? The error message must be erroneous.