Maniphest T66275

Should be possible to configure the footer of Minerva skin
Closed, ResolvedPublic
Actions

Description

On my wiki there are two links in the Mobile menu,
about and disclaimers.

I do not have an about page and thus do not wish this useless link to
appear on the screen.

There is also the Privacy link shown at the bottom of every screen.

I do not have such page, and thus do not wish users to be clicking there
only to find nothing.

I also don't want to put "-" in even more pages I would have to
maintain. bug 63422#c3 .

In bug 63414#c5 it says I should request a configuration variable.

Acceptance criteria

There is a $wgMinervaFooterConfiguration global. It is an array of keys defining what shows in the footer. When an item is removed the corresponding feature is removed from the footer
The config value applies to both stable and beta modes. It should not be possible to display different footers in desktop and mobile

[ 'about', 'privacy' ]

Details

Reference: bz64275

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:11 AM

• bzimport added a project: MobileFrontend-Feature-requests.

• bzimport set Reference to bz64275.

• bzimport added a subscriber: Unknown Object (MLST).

Jidanni created this task.Apr 23 2014, 6:18 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1956

@Mobile-Team: Is it still actual, that privacy message must be an own message key? I ask because for about and disclaimer we use core message key?
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinerva.php#L631

Yeh not sure what the current status of this is @kaldari any ideas?

Jdlrobson moved this task from Needs triage to In Discussion / Open Questions on the MobileFrontend-Feature-requests board.Jan 1 2015, 12:27 AM

iirc i already added a change for it, so in actual master we still use core message keys and if they are disabled, we don't show these links, see https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinerva.php#L696

As an example: http://www.droidwiki.de/?useformat=mobile (no about link, only "Impressum", which is the disclaimers message key). So i would mark this task as invalid? (Or resolved?)

Ah, here is the commit, i think i forgot to add teh bug there: https://gerrit.wikimedia.org/r/#/c/144280/

Currently http://abj.jidanni.org/ still
shows a link to "Privacy" at the very bottom when viewed in mobile, but not in desktop.

@Jidanni: You're right, as long as this message has "Privacy" as content, the link will be visible. If you replace it with "-" it shouldn't be.

http://abj.jidanni.org/index.php?title=MediaWiki:Mobile-frontend-privacy-link-text

@Jdlrobson and @kaldari Argh, i see i closed this task to fast, there is still the question, if we really need our own privacy message key, and if so: for what :)

I already have a "-" in
http://abj.jidanni.org/index.php?title=MediaWiki:Privacy
to zap it on Desktop according to Desktop rules.
Please have Mobile be aware of this too. Thanks!

You could have your algorithm use MediaWiki:Privacy if no MediaWiki:Mobile-frontend-privacy-link-text is found.

The reason for the mobile privacy key is that privacy message on desktop may wish to be more verbose but yes it should be completely optional and fallback to desktop privacy message if absent.

Please submit a patch with some tests in place since this sort of thing can easily break!

Jdlrobson moved this task from In Discussion / Open Questions to Should have on the MobileFrontend-Feature-requests board.Mar 4 2015, 7:19 PM

Thank you but someone else please make the patch.

@Jidanni if you need this urgently I urge you to find someone willing to that would be great otherwise your at the mercy of someone's generosity and we are a very small team and this is currently a low priority.

I got this task assigned, because i closed it. Now it's reopened, but i will not work on it.

Jdlrobson renamed this task from configuration variable to turn on or off particular footer links (both on desktop and mobile) to Should be possible to configure the footer of Minerva skin.Apr 13 2017, 8:09 PM

Jdlrobson edited projects, added MobileFrontend, Web-Team-Backlog; removed MobileFrontend-Feature-requests.

Jdlrobson added projects: patch-welcome, good first task.Apr 24 2017, 4:59 PM

Jdlrobson updated the task description. (Show Details)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 24 2017, 4:59 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Apr 24 2017, 4:59 PM

Jdlrobson added a project: Reading-Web-Third-Party-Support.May 21 2017, 1:14 PM

Jdlrobson added a project: MinervaNeue.Jun 23 2017, 8:31 PM

Jdlrobson moved this task from Backlog to 3rd party support on the MinervaNeue board.Jun 30 2017, 9:13 PM

Jdlrobson edited projects, added MinervaNeue (3rd party support); removed MinervaNeue.

Jdlrobson removed a project: MobileFrontend.Jul 13 2017, 5:58 PM

Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Aug 17 2017, 3:42 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.

The footer for Minerva is now identical to desktop. It can be configured with css.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJun 10 2020, 3:34 PM

Should be possible to configure the footer of Minerva skinClosed, ResolvedPublicActions

Description

Acceptance criteria

Details

Event Timeline

Should be possible to configure the footer of Minerva skin
Closed, ResolvedPublic
Actions