Page MenuHomePhabricator

[EPIC] Move Nearby code to more suitable extension
Open, LowPublic

Description

This would require moving some of our code and putting it into a new extension.

This would probably be a useful for code sharing between Flow, MobileFrontend and Geodata so is probably a good idea.

Options:

  • move it into GeoData
    • GeoData is a data-only extension and should remain so
  • Kartographer
    • Makes it easier to integrate with maps.
    • Makes this extension depend on GeoData extension
    • Makes it harder to use this functionality without setting up all the maps stuff
  • New Extension
    • More extensions to maintain.
    • Isolated from other code
    • Will depend on GeoData and Kartographer

Version: unspecified
Severity: normal

Details

Reference
bz64316

Related Objects

StatusAssignedTask
ResolvedDannyH
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenJdlrobson
DeclinedNone
ResolvedJdlrobson
Resolvedbmansurov
DeclinedNone
ResolvedJdlrobson
InvalidNone
Duplicate Nirzar
Openmarcella
ResolvedJdlrobson
DeclinedNone
ResolvedEsanders
ResolvedEsanders
Resolvedmatmarex
Resolvedmatmarex
Resolvedovasileva
ResolvedABorbaWMF
ResolvedNone
DuplicateNone
DuplicateNone
ResolvedJdlrobson
Resolvedbmansurov

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:13 AM
bzimport set Reference to bz64316.
  • Bug 64029 has been marked as a duplicate of this bug. ***

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/OLxnuzXR

MaxSem added a subscriber: MaxSem.May 26 2015, 9:22 PM

At this point I'm opposed to moving this to GeoData because it's a purely data-supplying extension. Instead, a separate extension should be created that would support displaaying POIs not only in a list but also optionally in a map, IMO.

Nemo_bis renamed this task from [Tracking] Move Nearby code to Geodata extension to Move Nearby code to Geodata extension (tracking).Jul 19 2015, 9:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 9:59 AM
Jdlrobson renamed this task from Move Nearby code to Geodata extension (tracking) to Move Nearby code to more suitable extension (tracking).Jul 19 2015, 8:33 PM
Jhernandez triaged this task as Normal priority.Aug 18 2015, 5:33 PM
Jhernandez added a subscriber: Jhernandez.
Jdlrobson moved this task from Backlog to Tasks on the MobileFrontend board.Nov 4 2015, 5:27 PM
Danny_B moved this task from Unsorted to Move on the Technical-Debt board.Jan 23 2016, 12:19 AM
Jdlrobson moved this task from Tasks to Tech debt on the MobileFrontend board.Feb 18 2016, 6:43 PM
MaxSem moved this task from Backlog to Tracking on the GeoData board.Mar 30 2017, 4:44 PM
Jdlrobson renamed this task from Move Nearby code to more suitable extension (tracking) to [EPIC] Move Nearby code to more suitable extension.May 3 2017, 6:03 PM
Jdlrobson lowered the priority of this task from Normal to Low.
Jdlrobson added a project: Epic.
Jdlrobson removed a project: Tracking-Neverending.

@TheDJ what do you think about putting the code into the Maps extension? I see from your email to maps-l you'd like to improve the page and doing this task seems like a good springboard to that....

TheDJ updated the task description. (Show Details)Aug 31 2017, 9:29 AM
TheDJ added a comment.Aug 31 2017, 9:31 AM

I think i'm personally in favour of moving it into either Kartographer, or a separate extension..

My biggest concern with putting it into Kartographer, is that I have no feeling for how intertwined that special page, it's JS and it's testcases currently are with MobileFrontend.

My biggest concern with putting it into Kartographer, is that I have no feeling for how intertwined that special page, it's JS and it's testcases currently are with MobileFrontend.

So the main problem is all the JavaScript of Naearby is in MobileFrontend and used by Minerva (and one of the reasons for that dependency)
The only way to avoid this dependency would be to rewrite the special page's JavaScript (maybe using OOjs UI)

If we took this approach we could have a temporary hidden Special page e.g. Special:NearbKartographer, and when it's ready we can simply switch the current special page with the new one.

This might also be a good time to revisit the hacky behaviour of the Nearby refresh icon which replaces the Echo notifications icon - I've always felt that belonged outside the header an how. cc @Nirzar

Am happy to provide responsive code review support for this initiative if you bite!

MaxSem updated the task description. (Show Details)Aug 31 2017, 6:07 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptAug 2 2019, 5:00 PM