Page MenuHomePhabricator

[Regression] mediawiki.util broken under target=mobile (unknown dependency jquery.accessKeyLabel)
Closed, ResolvedPublic

Description

The mobile site is currently broken on beta labs due to this rogue mobile that is currently not allowed on mobile.

JavaScript exception thrown.
Stops execution of rest of site.


Version: 1.24rc
Severity: blocker
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64513

Details

Reference
bz64512

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:09 AM
bzimport added a project: MediaWiki-JavaScript.
bzimport set Reference to bz64512.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1973

Change 129976 had a related patch set uploaded by Krinkle:
jquery.accessKeyLabel: Enable for target=mobile

https://gerrit.wikimedia.org/r/129976

Change 129976 merged by jenkins-bot:
jquery.accessKeyLabel: Enable for target=mobile

https://gerrit.wikimedia.org/r/129976

TheDJ added a comment.Apr 27 2014, 6:38 PM

This seems somewhat fragile.. Also I think the entire mobile target doesn't even use access keys, so we probably should decouple this in some way ?

Yeh it doesn't look like this library should be a core dependency. It suggests maybe it should/could be split up more.

TheDJ are you referring to the targets property being fragile? Alas it is but it's proved the safest way to ensure unnecessary unused code doesn't get loaded on mobile.

Opened new bug 64564