Page MenuHomePhabricator

Migrate css rules in hacks.less into templates
Open, NormalPublic

Description

The MobileFrontend extension has a file called hacks.less

http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend/8d9184c2d4af6e460ccea44be32b88db6565afc7/less%2Fcommon%2Fhacks.less

The purpose of this style is to optimise various user created templates for mobile devices by overriding existing known inline styles. It does this by using !important which is the only way to override an inline style.

Ideally this file shouldn't exist. All the components should have CSS which optimise the template for various display sizes.

The creation of a mechanism to style templates would provide a great generic solution to this problem:
https://www.mediawiki.org/wiki/Requests_for_comment/Allow_styling_in_templates


Version: unspecified
Severity: normal

Details

Reference
bz64578

Related Objects

StatusAssignedTask
Open Jdlrobson
ResolvedTgr
ResolvedAnomie
Resolvedtstarling
Resolvedcoren
ResolvedAnomie
StalledMhurd
ResolvedAnomie
ResolvedEsanders
ResolvedEsanders
Resolvedssastry
ResolvedAnomie
ResolvedCKoerner_WMF
Resolvedjhsoby
ResolvedTgr
DeclinedTgr
Resolvedcoren
ResolvedAnomie
ResolvedTgr
OpenNone
OpenNone
ResolvedTgr
ResolvedTgr
ResolvedTgr
ResolvedDeskana
ResolvedCKoerner_WMF
ResolvedWhatamidoing-WMF
ResolvedTgr
ResolvedTgr
ResolvedTgr
ResolvedUrbanecm
ResolvedTgr
ResolvedTacsipacsi
ResolvedTgr
ResolvedCKoerner_WMF

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz64578.
Nemo_bis renamed this task from [Tracking] Migrate css rules in hacks.less into templates. to Migrate css rules in hacks.less into templates (tracking).Jul 19 2015, 9:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 9:59 AM
Jhernandez triaged this task as Low priority.Aug 18 2015, 5:10 PM
Jhernandez added a subscriber: Jhernandez.
resources/skins.minerva.content.styles/hacks.less
resources/skins.minerva.tablet.beta.styles/hacks.less
resources/skins.minerva.tablet.styles/hacks.less
Phabricator_maintenance renamed this task from Migrate css rules in hacks.less into templates (tracking) to Migrate css rules in hacks.less into templates.Aug 13 2016, 11:28 PM
Jdlrobson raised the priority of this task from Low to Normal.
Jdlrobson moved this task from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Jdlrobson moved this task from Backlog to Tracking on the MinervaNeue board.Aug 16 2017, 8:49 PM
Jdlrobson moved this task from Tracking to 3rd party support on the MinervaNeue board.
TheDJ added a subscriber: TheDJ.Aug 3 2018, 9:42 AM

I've moved the quote box 'hacks' into https://en.wikipedia.org/wiki/Template:Quote_box/styles.css
Will move to getting that deployed, so that we can remove that specific hack from less.css