Page MenuHomePhabricator

VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector
Closed, ResolvedPublic

Description

Screenshot of view and edit mode side-by-side

Ever since the typography update, the content looks malformed in the editor.

This is because the way the typography change in Vector was implemented, used rather specific selectors that cannot apply to VisualEditor's surface and thus it cascades in ways it wasn't supposed to.

The content line-height is squished, and the font size is too small.


Version: unspecified
Severity: major

Attached:

Details

Reference
bz64599

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:15 AM
bzimport set Reference to bz64599.
Krinkle created this task.Apr 29 2014, 11:53 AM

Change 129567 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Use .mw-content for content styling

https://gerrit.wikimedia.org/r/129567

Change 130507 had a related patch set uploaded by Jforrester:
mw.ViewPageTarget: Use .mw-body-content for content styling

https://gerrit.wikimedia.org/r/130507

Change 129567 merged by jenkins-bot:
mw.ViewPageTarget: Use .mw-body-content for content styling

https://gerrit.wikimedia.org/r/129567

Change 130507 merged by jenkins-bot:
mw.ViewPageTarget: Use .mw-body-content for content styling

https://gerrit.wikimedia.org/r/130507

Still some mess here.

Change 130541 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface

https://gerrit.wikimedia.org/r/130541

Yeah, we fixed the page content font-size and line-height, but now those changes incorrectly apply to our overlays as well. This causes all our inspectors to have messed up line-heights and recursively smaller font-sizes inside e.g. link inspector suggestions and the context menu cursor.

(In reply to Krinkle from comment #7)

Yeah, we fixed the page content font-size and line-height, but now those
changes incorrectly apply to our overlays as well. This causes all our
inspectors to have messed up line-heights and recursively smaller font-sizes
inside e.g. link inspector suggestions and the context menu cursor.

https://gerrit.wikimedia.org/r/130541 addresses this.

Change 130541 merged by jenkins-bot:
mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface

https://gerrit.wikimedia.org/r/130541

Change 130745 had a related patch set uploaded by Catrope:
mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface

https://gerrit.wikimedia.org/r/130745

Change 130745 merged by Catrope:
mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface

https://gerrit.wikimedia.org/r/130745

Verified the fix on Betalabs and test2

Verified the fix on production