Page MenuHomePhabricator

VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer selected on action=edit
Closed, ResolvedPublic

Description

In Vector/1.24wmf2, the "Edit source" tab is not highlighted when editing a page in source mode (no tab is highlighted).

Example:
http://www.mediawiki.org/w/index.php?title=Help:Preferences&action=edit


Version: unspecified
Severity: major

Details

Reference
bz64646

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:18 AM
bzimport set Reference to bz64646.

Caused by Ib2e6237483338c8072d5f7919c6459bf7418946a, which overides the 'class' attribute of the original edit tab with 'collapsed'. Thus blowing away the class "selected" that MediaWiki core puts there when on action=edit.

Change 130594 had a related patch set uploaded by Krinkle:
Preserve pre-existing css classes on edit tab link.

https://gerrit.wikimedia.org/r/130594

(For the record, yes, confirmed this is broken in production and on latest master).

  • Bug 64645 has been marked as a duplicate of this bug. ***

Change 130594 merged by jenkins-bot:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130594

Change 130622 had a related patch set uploaded by Jforrester:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130622

Change 130622 merged by Catrope:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130622

Verified the fix on Production, Betalabs and Test2