Page MenuHomePhabricator

Manage z-index with LESS variables
Closed, ResolvedPublic

Description

z-index's can be a pain and result in z-index wars where the z-index continues to get upped!

Let's create some LESS variables that define logical layers for all usages.

e.g.
@z-index-article
@z-index-overlay
@z-index-overlay-widget


Version: unspecified
Severity: normal

Details

Reference
bz64707

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:22 AM
bzimport set Reference to bz64707.
Jdlrobson created this task.May 1 2014, 4:41 PM

Change 139568 had a related patch set uploaded by Florianschmidtwelzow:
Hygiene: Manage z-index with less variables

https://gerrit.wikimedia.org/r/139568

FWIW, the element <div class="transparent-shield cloaked-element"> shows up at the "top" of the z-index stack for a brief period when loading pages, and causes browser tests run locally in Chrome to fail from time to time:

Given I am logged into the mobile website # features/step_definitions/common_steps.rb:12

unknown error: Element is not clickable at point (130, 323). Other element would receive the click: <div class="transparent-shield cloaked-element"></div>
  (Session info: chrome=35.0.1916.153)
  (Driver info: chromedriver=2.10.267517,platform=Mac OS X 10.9.3 x86_64) (Selenium::WebDriver::Error::UnknownError)
./features/step_definitions/mainmenu_steps.rb:7:in `/^I click on "(.*?)" in the main navigation menu$/'
./features/step_definitions/common_steps.rb:14:in `/^I am logged into the mobile website$/'
features/special_uploads.feature:9:in `Given I am logged into the mobile website'

I have not figured out what function the <div class="transparent-shield cloaked-element"> serves.

Change 139568 merged by jenkins-bot:
Hygiene: Manage z-index with less variables

https://gerrit.wikimedia.org/r/139568