VisualEditor: Citation tool should not add empty citation templates
Closed, ResolvedPublic

Description

Steps to Reproduce:

  1. Citation > Cite web
  1. Don't add any information. Just click "Apply changes".

Result: <ref>{{Cite web|url = |title = |date = |accessdate = |website = }}</ref>

That's pointless. If the fields are blank, don't add it (or remove it).

Steps to reproduce, part 2:

  1. Citation > Cite web
  1. Don't add any information. Delete all the parameters.
  1. Click "Apply changes".

Result: <ref>{{Cite web}}</ref>

That's even more pointless. If there are no parameters, don't add it (or remove it).

Reproducible: Didn't try

(The "invalid" parameter in that diff was manually created by me. I don't think you can do anything to help the person adding invalid parameters, because there's no way to differentiate between invalid parameter names and valid names that don't happen to be defined in TemplateData.)


Version: unspecified
Severity: minor
URL: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Whatamidoing_(WMF)/Sandbox&diff=91690&oldid=91686

bzimport set Reference to bz64715.
Whatamidoing-WMF created this task.Via LegacyMay 1 2014, 8:41 PM
gerritbot added a comment.Via ConduitMay 30 2014, 7:37 PM

Change 136436 had a related patch set uploaded by Alex Monk:
Don't allow inserting blank citations

https://gerrit.wikimedia.org/r/136436

gerritbot added a comment.Via ConduitJun 4 2014, 10:57 PM

Change 136436 merged by jenkins-bot:
Don't allow inserting blank citations

https://gerrit.wikimedia.org/r/136436

Mvolz added a comment.Via ConduitJun 5 2014, 6:44 PM

Created attachment 15573
More than one field error

Attached:

Mvolz added a comment.Via ConduitJun 5 2014, 6:45 PM

Whoops, sorry, wrong bug report :(

Add Comment