Page MenuHomePhabricator

[dismiss] does not dismiss DismissableSiteNotice banner on mobile
Closed, ResolvedPublic

Description

Not dismissed

Steps to reproduce:

  1. Go to https://en.m.wikivoyage.org/wiki/Main_Page#
  2. Click on [dismiss] at the left of the banner
  3. PROBLEM: Banner not dismissed

Similar to https://bugzilla.wikimedia.org/show_bug.cgi?id=29402 which was "fixed" in 2011 by removing the banner.


Version: unspecified
Severity: normal
Platform: Smartphone

Attached:

Details

Reference
bz64737

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:25 AM
bzimport set Reference to bz64737.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/cM6a95iD

How is the banner generated? Via CentralNotice?
If so can you link us to the banner of meta wiki?

mwalker wrote:

Jon; this is actually a dismissable site notice on enwikivoyage:
https://en.wikivoyage.org/wiki/MediaWiki:Sitenotice

  • This bug has been marked as a duplicate of bug 64716 ***

I'm pretty sure it's not a dupe of that. No local storage issues in console....

My local storage has plenty of space... must be something different?

Change 131111 had a related patch set uploaded by Krinkle:
Make site notices dismissable on mobile

https://gerrit.wikimedia.org/r/131111

Change 131111 merged by jenkins-bot:
Make site notices dismissable on mobile

https://gerrit.wikimedia.org/r/131111