Page MenuHomePhabricator

ResourceLoader: load.php requests with only=styles should report if module is missing
Closed, ResolvedPublic

Description

Sometimes when messing locally with different things, a page might look broken.

Then I look at the response for a request like:

/load.php?debug=false&lang=en&modules=mediawiki.skinning.interface%7Cskins.vector.styles&only=styles&skin=vector&*

And it's near impossible to figure out that something is wrong. In this case, module "mediawiki.skinning.interface" could not be found.

debug=true makes no difference in this regard.

Had it been a regular request that isn't only=styles, it would've contained :

mw.loader.state({"mediawiki.skinning.interface":"missing"});

We should probably treat this the same as we do in case of exceptions and other errors in stylesheet requests, namely by prepending a comment to the response body.


Version: unspecified
Severity: normal

Details

Reference
bz64826

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:13 AM
bzimport set Reference to bz64826.
Krinkle created this task.May 4 2014, 2:33 PM

Change 131342 had a related patch set uploaded by Krinkle:
resourceloader: Report problematic modules in only=styles as well

https://gerrit.wikimedia.org/r/131342

Change 131342 merged by jenkins-bot:
resourceloader: Report problematic modules in only=styles as well

https://gerrit.wikimedia.org/r/131342