Page MenuHomePhabricator

Reenable content model support for Syntaxhighlight
Closed, ResolvedPublic

Description

This https://gerrit.wikimedia.org/r/#/c/52268/ was never re-enabled.


Version: master
Severity: normal

Details

Reference
bz64859

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:15 AM
bzimport set Reference to bz64859.
TheDJ created this task.May 5 2014, 12:26 AM
TheDJ added a comment.May 5 2014, 1:01 AM

Because of this, in https://gerrit.wikimedia.org/r/#/c/126843 we patched the wrong function. Also when fixing the right function, it seems the fix doesn't work....

:(

Maybe related: bug 27397?

We should probably explicitly drop compatibility with older MWs on SyntaxHighlight master already.

Plot twist: core support for this was reverted in https://gerrit.wikimedia.org/r/#/c/67860/. The code implementing this in SyntaxHighlight is thus entirely and wholly dead.

There is a revert of the revert pending at https://gerrit.wikimedia.org/r/#/c/67983/.

Change 131447 had a related patch set uploaded by Bartosz Dziewoński:
[DOES NOT WORK] Use ContentGetParserOutput hook instead of ShowRawCssJs

https://gerrit.wikimedia.org/r/131447

Change 131502 had a related patch set uploaded by Bartosz Dziewoński:
Article: Add entire ParserOutput in showCssOrJsPage() like in view()

https://gerrit.wikimedia.org/r/131502

(In reply to Gerrit Notification Bot from comment #5)

[DOES NOT WORK] Use ContentGetParserOutput hook instead of ShowRawCssJs

Does work now with the core patch above (and all of its dependencies).

Change 131502 merged by jenkins-bot:
Article: Add RL modules for the ParserOutput when showing CSS/JS page

https://gerrit.wikimedia.org/r/131502

Change 131447 merged by jenkins-bot:
Use ContentGetParserOutput hook instead of ShowRawCssJs

https://gerrit.wikimedia.org/r/131447

Hooray, this will work again!