Page MenuHomePhabricator

Echo flyout does not open on some pages when Compact Personal Bar is enabled
Closed, DeclinedPublic

Description

When compact personal bar is enabled echo flyout should be displayed when the icon is hovered over, and all notification should be displayed when clicked.

See also:
T72383: Recommendations flyout link does not appear if user has Compact Personal Toolbar beta feature
T67073: "skins.vector.compactPersonalBar" breaks mw.util.addPortletLink for gadgets, user scripts and other extensions

Details

Reference
bz64862

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:15 AM
bzimport set Reference to bz64862.

echo flyout is still broken on most pages but occasionally works on the main page of wikipedia

I've seen this too on beta labs. The Echo flyout usually (always?) appears if I append ?debug=1, so it's hard to debug.

mw.loader.getState( 'ext.echo.overlay.init' ) returns "ready" in both cases. It seems when the flyout doesn't appear, Echo neither logs its badge click event nor does it issue its API query for notifications. Maybe $( '#pt-notifications a') does not exist when ext.echo.overlay.js runs?

See also bug 70383

I know Juliusz was having trouble tracking down this issue as well, its a major blocker on the feature, it would be great if someone could tackle it.

Prtksxna triaged this task as High priority.Dec 3 2014, 10:33 AM
Prtksxna updated the task description. (Show Details)
Prtksxna set Security to None.
Jaredzimmerman-WMF renamed this task from CPB: Echo flyout does not open when compact personal bar is enabled to Echo flyout does not open when compact personal bar is enabled.Dec 23 2014, 12:09 AM
Jaredzimmerman-WMF removed Prtksxna as the assignee of this task.
Quiddity renamed this task from Echo flyout does not open when compact personal bar is enabled to Echo flyout does not open when Compact Personal Bar is enabled.Dec 23 2014, 10:11 PM
Jaredzimmerman-WMF renamed this task from Echo flyout does not open when Compact Personal Bar is enabled to Echo flyout does not openon some pages when Compact Personal Bar is enabled.Dec 24 2014, 12:31 AM
CennoxX added a subscriber: CennoxX.Jan 1 2015, 3:05 PM
Quiddity renamed this task from Echo flyout does not openon some pages when Compact Personal Bar is enabled to Echo flyout does not open on some pages when Compact Personal Bar is enabled.Jan 8 2015, 12:45 AM
Jaredzimmerman-WMF lowered the priority of this task from High to Lowest.Jan 16 2015, 6:43 PM

I'm untriaging this, so the Collaboration team can triage and look at including this in a sprint.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 10 2015, 9:07 PM
Mattflaschen-WMF raised the priority of this task from Lowest to Needs Triage.Apr 10 2015, 9:08 PM
EBernhardson triaged this task as High priority.Apr 17 2015, 5:56 PM
EBernhardson added a subscriber: EBernhardson.
Aklapper lowered the priority of this task from High to Lowest.Jun 19 2015, 7:25 PM
Aklapper added a subscriber: Aklapper.
Legoktm moved this task from Backlog to External on the Notifications board.Jul 6 2015, 7:31 AM
Catrope closed this task as Declined.Aug 3 2015, 11:57 PM
Catrope claimed this task.
Catrope added a subscriber: Catrope.

Compact Personal Bar has been undeployed and is no longer supported.