Page MenuHomePhabricator

UploadWizard: Accept files whose names are invalid MediaWiki titles
Closed, ResolvedPublic

Description

How to reproduce:

  1. Go to https://commons.wikimedia.org/wiki/Special:UploadWizard
  2. Upload a file named "Abc[defg.jpg"
  3. You are shown an error message:

Could not understand the file name "Abc[defg.jpg".<<

You are unable to upload this file unless you rename it.

Expected:

Invalid character are simply dropped or replaced.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=60022
https://bugzilla.wikimedia.org/show_bug.cgi?id=57145

Details

Reference
bz64912

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz64912.
Rillke created this task.May 5 2014, 6:30 PM

Change 131691 had a related patch set uploaded by Rillke:
Accept files that have whose name are invalid titles

https://gerrit.wikimedia.org/r/131691

Change 131691 abandoned by Rillke:
Accept files whose name are invalid titles

Reason:
I'll submit a patch against mw.Title including unit tests

https://gerrit.wikimedia.org/r/131691

Change 131971 had a related patch set uploaded by Rillke:
mw.Title: Add new static method newFromFileName

https://gerrit.wikimedia.org/r/131971

  • You are unable to upload this file unless you rename it.

You have to rename it locally. It's not uploaded at all.

Change 131971 merged by jenkins-bot:
mw.Title: Add new static methods newFromFileName, newFromUserInput

https://gerrit.wikimedia.org/r/131971

Change 171546 had a related patch set uploaded by MarkAHershberger:
mw.Title: Add new static methods newFromFileName, newFromUserInput

https://gerrit.wikimedia.org/r/171546

Change 171546 merged by jenkins-bot:
mw.Title: Add new static methods newFromFileName, newFromUserInput

https://gerrit.wikimedia.org/r/171546

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:11 AM
Gilles raised the priority of this task from High to Unbreak Now!.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:21 AM