Page MenuHomePhabricator

Should not throw errors towards the JS error console if invalid title is specified
Closed, ResolvedPublic

Description

FF RC; Screenshot illustrating the issue

Issue: Uplaod form throws errors towards the JS error console if invalid title is specified

Reproducing:

  1. Go to https://commons.wikimedia.org/wiki/Special:Preferences#mw-prefsection-gadgets
    1. Disable the gadget "ImprovedUploadForm"
  2. Go to https://commons.wikimedia.org/w/index.php?title=Special:Upload&uselang=ownwork&debug=true
  3. Enter a title as the "Destination filename:" that is invalid e.g. containing a square bracket

Result:
Error: Unable to parse title
https://bits.wikimedia.org/static-1.24wmf2/resources/src/mediawiki/mediawiki.Title.js
Line 24


Version: 1.24rc
Severity: minor

Attached:

Details

Reference
bz64922

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz64922.
Rillke created this task.May 5 2014, 9:32 PM

Change 131971 had a related patch set uploaded by Rillke:
mw.Title: Add new static method newFromFileName

https://gerrit.wikimedia.org/r/131971

Change 131971 merged by jenkins-bot:
mw.Title: Add new static methods newFromFileName, newFromUserInput

https://gerrit.wikimedia.org/r/131971

Change 171546 had a related patch set uploaded by MarkAHershberger:
mw.Title: Add new static methods newFromFileName, newFromUserInput

https://gerrit.wikimedia.org/r/171546

Change 171546 merged by jenkins-bot:
mw.Title: Add new static methods newFromFileName, newFromUserInput

https://gerrit.wikimedia.org/r/171546

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:12 AM
Gilles raised the priority of this task from Low to Unbreak Now!.
Gilles lowered the priority of this task from Unbreak Now! to Low.Dec 4 2014, 11:20 AM