Page MenuHomePhabricator

[UIFeedback]: After closing screenshot dialog Firefox selects the whole text by a single click
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Load UIFeedback in screenshot mode by #screenshot.
  • Click on "Feedback" button

-> "Feedback" dialog occurs.

  • Click on the close button in the right top corner.

-> Dialog closes.

  • Click somewhere in the text.

-> The whole text gets selected.

This behavior occurs in Mozilla Firefox.
This behavior occurs not in Google Chrome.

To allow drawing before the screenshot the selection gets disabled by
user-select: none
That is correct.

After closing the selection should set back to normal mode. This is done by
user-select: all
That is wrong. The default value is
user-select: text
http://www.w3.org/TR/2000/WD-css3-userint-20000216#user-select
https://developer.mozilla.org/en-US/docs/Web/CSS/user-select

Webkit does not support (-webkit-)user-select: all
https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/css/property/-webkit-user-select

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:20 AM
bzimport set Reference to bz64941.

Change 131664 had a related patch set uploaded by Gerrit Patch Uploader:
Reset to the default user-select: text instead of user-select: all

https://gerrit.wikimedia.org/r/131664

Change 131664 had a related patch set uploaded (by TheDJ):
Use correct CSS default values

https://gerrit.wikimedia.org/r/131664

Change 131664 merged by jenkins-bot:
Use correct CSS default values

https://gerrit.wikimedia.org/r/131664

Fomafix updated the task description. (Show Details)
Fomafix removed a project: Patch-For-Review.