Page MenuHomePhabricator

WfTimestampTest::testOldTimestamps randomly fails for some users and on travis
Closed, ResolvedPublic

Description

Particularly with data set #12 and #13. See https://travis-ci.org/wikimedia/mediawiki-core/jobs/24510844#L352 on travis

The method gets most of the date correct but gets the day itself slightly wrong.

To me this looks like something that changes slightly from system to system.

The tests (or these 2 in particular) should probably be changed to ignore the changing day and just test the rest of the timestamp.


Version: 1.24rc
Severity: normal

Details

Reference
bz64946

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:20 AM
bzimport set Reference to bz64946.
bzimport added a subscriber: Unknown Object (MLST).
Addshore created this task.May 6 2014, 9:24 AM

Change 131674 had a related patch set uploaded by Addshore:
Ignore days of random failing tests in wfTimestampTest

https://gerrit.wikimedia.org/r/131674

Change 131674 merged by jenkins-bot:
Ignore days of random failing tests in wfTimestampTest

https://gerrit.wikimedia.org/r/131674

fred wrote:

Not random - the old value in the test was incorrect; this was fixed in recent versions of PHP and HHVM (due to a timelib update). More info in https://github.com/wikimedia/mediawiki-core/pull/19