Page MenuHomePhabricator

Show and hide gadgets depending on skin compatibility
Closed, DuplicatePublic

Description

Many gadgets are skin specific, it might be cleaner if only gadgets that were compatible with the current skin showed at any given time.


Version: unspecified
Severity: enhancement

Details

Reference
bz64975

Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:22 AM
bzimport set Reference to bz64975.
bzimport added a subscriber: Unknown Object (MLST).

For a real example:
https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition#appearance
has

  • VectorClassic[ResourceLoader|skins=vector]|VectorClassic.css

and
and the option "Vector classic typography (use only sans-serif in Vector skin)" should not appear on
https://en.wikipedia.org/wiki/Special:Preferences?useskin=monobook#mw-prefsection-gadgets

This is already supported, save for the bug Helder pointed out (which already has a bug report).

  • This bug has been marked as a duplicate of bug 63532 ***

Hm.. I was pretty sure this was supported, then I tested with the url above and it didn't work, so I just posted the example... I completely forgot that I reported the problem with the useskin parameter.

Created attachment 15316
non-vector compatible gadgets showing when vector is enabled

Attached:

Screenshot_2014-05-07_13.24.24.png (360×915 px, 91 KB)

Isn't the bug you marked this as a dupe of, only for when your using different skins via a url switch, rather than when its enabled as your normal skin?

I do not have the ability to edit English Wikipedia's gadgets definition to make these actually depend on the skin. We do not support natural language processing…

(In reply to Jared Zimmerman (WMF) from comment #6)

Isn't the bug you marked this as a dupe of, only for when your using
different skins via a url switch, rather than when its enabled as your
normal skin?

Yes. When it is enabled as a normal skin, this works, as long as the dependency is specified in the gadgets definition. I supposed it could be RESOLVED WORKSFORME instead.

Do gadgets not have a value or flag in them to say what skin they are compatible with?

Bartosz, you can see from my screenshot is does not work. I have vector enabled as a normal skin (not a url switch) and I'm seeing monobook only gadgets

(In reply to Jared Zimmerman (WMF) from comment #9)

Do gadgets not have a value or flag in them to say what skin they are
compatible with?

They have, 'skins='. However, the ones on the English Wikipedia do not have this flag set correctly (other than one which is set to depend on Vector), see [[en:MediaWiki:Gadgets-definition]]. Local administrators can fix this, I can not.

[conflict]

(In reply to Jared Zimmerman (WMF) from comment #9)

Do gadgets not have a value or flag in them to say what skin they are
compatible with?

According to
https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition?oldid=606473655
there is only one gadget currently using the "skins=" parameter: VectorClassic.

The other gadgets in your screenshot need to be marked similarly, or they will show up and be loaded in every skin.

Ok so from what I've heard we don't log bugzilla tickets against individual gadgets, but I'm reopening this bug as a pseudo tracking bug while there are gadgets that don't have "skins=" parameter correctly set.

We don't use Bugzilla for tracking on-wiki issues. None of us discussing this here have the permissions necessary to fix the gadgets (unless you use your staff powers for this). Please raise this issue on the Village Pump on Wikipedia.

(In reply to Bartosz Dziewoński from comment #14)

We don't use Bugzilla for tracking on-wiki issues.

This actually isn't true in many cases. :-) (For example, we encourage small wikis to report site issues in Bugzilla where they'll get attention rather than on desolate and obscure local MediaWiki namespace talk pages.)

But in this particular case, making an on-wiki request is probably the best course of action given the vibrant technical community on the English Wikipedia.