Page MenuHomePhabricator
Create Task
Maniphest T67053

wikimedia/fundraising/dash.git should pass jshint
Closed, ResolvedPublic
Actions

Description

Sherah Smith added Jenkins jobs for the wikimedia/fundraising/dash.git repository with the changes https://gerrit.wikimedia.org/r/#q,Iad288c74f96ad19da35c66d86ace1b196f61a0fd,n,z

Unfortunately it does not pass jshint yet which is causing the job to fail and vote -2 in Gerrit. Will make it non voting for now, but it would be nice to fix the jshint errors.

Details

Reference
bz65053
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make jslint voting for fundraising-dashintegration/configmaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:10 AM
• bzimport added a project: Wikimedia-Fundraising.
• bzimport set Reference to bz65053.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.May 9 2014, 8:08 AM
gerritbot added a comment.May 9 2014, 8:10 AM

Change 132343 had a related patch set uploaded by Hashar:
wikimedia-fundraising-dash-jslint non voting

https://gerrit.wikimedia.org/r/132343

gerritbot added a comment.May 9 2014, 8:12 AM

Change 132343 merged by jenkins-bot:
wikimedia-fundraising-dash-jslint non voting

https://gerrit.wikimedia.org/r/132343

gerritbot added a project: Patch-For-Review.Dec 16 2014, 7:15 PM

Change 180226 had a related patch set uploaded (by Krinkle):
Make jslint voting for fundraising-dash

https://gerrit.wikimedia.org/r/180226

Patch-For-Review

Krinkle updated the task description. (Show Details)Dec 16 2014, 7:16 PM
Krinkle edited projects, added Zuul; removed Patch-For-Review.
Krinkle set Security to None.
Krinkle edited subscribers, added: Krinkle, awight; removed: Unknown Object (MLST).

It's passing as of https://gerrit.wikimedia.org/r/#/c/180223/.

gerritbot added a comment.Dec 16 2014, 7:17 PM

Change 180226 merged by jenkins-bot:
Make jslint voting for fundraising-dash

https://gerrit.wikimedia.org/r/180226

hashar closed this task as Resolved.Dec 16 2014, 10:27 PM
hashar claimed this task.

Solved, congratulations!

Krinkle mentioned this in rCICF2e282a902773: Make jslint voting for fundraising-dash.Dec 31 2014, 6:28 PM
Krinkle edited projects, added Continuous-Integration-Infrastructure; removed Zuul.Apr 15 2015, 10:35 PM
Krinkle moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.Apr 16 2015, 3:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits